* [PATCH] ARM: i.MX: dts: imx93-tqma9352-mba93xxla: add eeprom aliases
@ 2025-12-05 14:31 Sascha Hauer
2025-12-05 14:33 ` Ahmad Fatoum
0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2025-12-05 14:31 UTC (permalink / raw)
To: Barebox List
eeprom0 has an alias in the upstream device tree whereas the other
EEPROMs have not. Add aliases for the other EEPROMs. Without it the
other devices will also try to register themselves as eeprom0 which
fails with -EEXIST.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/dts/imx93-tqma9352-mba93xxla.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/dts/imx93-tqma9352-mba93xxla.dts b/arch/arm/dts/imx93-tqma9352-mba93xxla.dts
index d1d68a55e1..4b1624cdaa 100644
--- a/arch/arm/dts/imx93-tqma9352-mba93xxla.dts
+++ b/arch/arm/dts/imx93-tqma9352-mba93xxla.dts
@@ -3,3 +3,10 @@
#include <arm64/freescale/imx93-tqma9352-mba93xxla.dts>
#include "imx93.dtsi"
#include "imx93-tqma93xx.dtsi"
+
+/ {
+ aliases {
+ eeprom1 = &eeprom1;
+ eeprom2 = &eeprom2;
+ };
+};
--
2.47.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: i.MX: dts: imx93-tqma9352-mba93xxla: add eeprom aliases
2025-12-05 14:31 [PATCH] ARM: i.MX: dts: imx93-tqma9352-mba93xxla: add eeprom aliases Sascha Hauer
@ 2025-12-05 14:33 ` Ahmad Fatoum
2025-12-08 12:02 ` Sascha Hauer
0 siblings, 1 reply; 3+ messages in thread
From: Ahmad Fatoum @ 2025-12-05 14:33 UTC (permalink / raw)
To: Sascha Hauer, Barebox List
Hi,
On 12/5/25 3:31 PM, Sascha Hauer wrote:
> eeprom0 has an alias in the upstream device tree whereas the other
> EEPROMs have not. Add aliases for the other EEPROMs. Without it the
> other devices will also try to register themselves as eeprom0 which
> fails with -EEXIST.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Should we fix the driver to use dynamic IDs in absence of EEPROMs?
We could use of_alias_get_highest_id() to get a start ID.
Cheers,
Ahmad
> ---
> arch/arm/dts/imx93-tqma9352-mba93xxla.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/dts/imx93-tqma9352-mba93xxla.dts b/arch/arm/dts/imx93-tqma9352-mba93xxla.dts
> index d1d68a55e1..4b1624cdaa 100644
> --- a/arch/arm/dts/imx93-tqma9352-mba93xxla.dts
> +++ b/arch/arm/dts/imx93-tqma9352-mba93xxla.dts
> @@ -3,3 +3,10 @@
> #include <arm64/freescale/imx93-tqma9352-mba93xxla.dts>
> #include "imx93.dtsi"
> #include "imx93-tqma93xx.dtsi"
> +
> +/ {
> + aliases {
> + eeprom1 = &eeprom1;
> + eeprom2 = &eeprom2;
> + };
> +};
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: i.MX: dts: imx93-tqma9352-mba93xxla: add eeprom aliases
2025-12-05 14:33 ` Ahmad Fatoum
@ 2025-12-08 12:02 ` Sascha Hauer
0 siblings, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2025-12-08 12:02 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: Barebox List
On Fri, Dec 05, 2025 at 03:33:29PM +0100, Ahmad Fatoum wrote:
> Hi,
>
> On 12/5/25 3:31 PM, Sascha Hauer wrote:
> > eeprom0 has an alias in the upstream device tree whereas the other
> > EEPROMs have not. Add aliases for the other EEPROMs. Without it the
> > other devices will also try to register themselves as eeprom0 which
> > fails with -EEXIST.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> Should we fix the driver to use dynamic IDs in absence of EEPROMs?
Yes, but I needed you to motivate me to jump into this rabbit hole ;)
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-08 12:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-05 14:31 [PATCH] ARM: i.MX: dts: imx93-tqma9352-mba93xxla: add eeprom aliases Sascha Hauer
2025-12-05 14:33 ` Ahmad Fatoum
2025-12-08 12:02 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox