mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Alexander Shiyan <eagle.alexander923@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] ARM: DTS: myir-x335x: Add GPIO aliases
Date: Wed, 25 May 2022 10:52:27 +0200	[thread overview]
Message-ID: <2219b846-67e1-ba45-cca2-11d304e55bcd@pengutronix.de> (raw)
In-Reply-To: <CAP1tNvTqa-qVTBCR1QQptsfvgTWsWNCEGSFG+ZnvNrBT62cabg@mail.gmail.com>

Hello Alexander,

On 25.05.22 10:33, Alexander Shiyan wrote:
>>> Most likely this is the result of double inclusion of the file arm/am33xx.dtsi,
>>> first time from "am33xx.dtsi" and second from arm/am335x-myirtech-myd.dts.
>>
>> Hi, you need to include if after the upstream DT. That's why it doesn't have
>> a /dts-v1/;
> 
> Yes, if "am33xx.dtsi" is after <arm/am335x-myirtech-myd.dts>, it compiles fine.
> But in this case, upstreaming <arm/am33xx.dtsi> (from local
> am33xx.dtsi) overwrites
> any binding changes from the board file.

Argh. Other platforms (e.g. imx6q.dtsi) intentionally skip dts/ includes to avoid
just that... One could remedy that at the cost of annoying out-of-tree users, but
that's not something that you need to do IMO.

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Cheers,
Ahmad

> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2022-05-25  8:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24  7:30 Alexander Shiyan
2022-05-24  9:03 ` Marco Felsch
2022-05-24  9:21   ` Alexander Shiyan
2022-05-24 12:03     ` Marco Felsch
2022-05-24 12:28 ` Ahmad Fatoum
2022-05-25  6:23   ` Marco Felsch
2022-05-25  6:27   ` Alexander Shiyan
2022-05-25  8:16     ` Ahmad Fatoum
2022-05-25  8:33       ` Alexander Shiyan
2022-05-25  8:52         ` Ahmad Fatoum [this message]
2022-05-30  6:55 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2219b846-67e1-ba45-cca2-11d304e55bcd@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=eagle.alexander923@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox