From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] net: dsa: realtek: fix Kconfig selects
Date: Fri, 19 May 2023 10:59:04 +0200 [thread overview]
Message-ID: <232d7d20-8c3b-bbd5-2150-fc404099a6ed@pengutronix.de> (raw)
In-Reply-To: <CAA4bVAEtTi0+gYRd04ou+Cv6vDaHd_Q5+hzM5zfEtpGe5=qswQ@mail.gmail.com>
On 11.05.23 10:35, Antony Pavlov wrote:
> Hi Ahmad!
>
> On Wed, 3 May 2023 at 13:08, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>
>> Unlike Linux, barebox has no CONFIG_FIXED_PHY or CONFIG_IRQ_DOMAIN.
>> The former is implied by CONFIG_PHYLIB and the latter is unneeded, so
>> revise the Kconfig option accordingly.
>
> You can drop 'select REGMAP' too.
>
> It looks like there are several undeclared Kconfig options.
>
> I used these commands to find them:
>
> find -iname 'Kconfig*' -type f -exec cat {} ';' | grep "\(^\s*menuconfig
> \|^\s*config \)" | sed "s/^\s*//" | sed "s/^config //" | sed
> "s/^menuconfig //" | grep "^[A-Z]" | sed "s/ *#.*$//" | sed "s/ if .*$//" |
> sed "s/\s*$//" | sort | uniq > /tmp/config
> find -iname 'Kconfig*' -type f -exec cat {} ';' | grep "^\s*select " | sed
> "s/^\s*//" | sed "s/^select //" | grep "^[A-Z]" | sed "s/ *#.*$//" | sed
> "s/ if .*$//" | sed "s/\s*$//" | sort | uniq > /tmp/select
> diff -u /tmp/select /tmp/config | grep ^- | grep -v "^---" | sed "s/^-//"
>
> diff output on the master branch is:
>
> CONFIG_ARCH_HAS_SJLJ
> CRYPTO_BLKCIPHER
> CRYPTO_DES
> REGMAP
Thanks. I had added scripts/kconfig-lint.py to catch such things, but
it got broken recently by the 32BIT/64BIT rework...
Cheers,
Ahmad
>
> --
> Best regards,
> Antony Pavlov
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-05-19 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 10:06 Ahmad Fatoum
2023-05-09 7:23 ` Sascha Hauer
[not found] ` <CAA4bVAEtTi0+gYRd04ou+Cv6vDaHd_Q5+hzM5zfEtpGe5=qswQ@mail.gmail.com>
2023-05-19 8:59 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=232d7d20-8c3b-bbd5-2150-fc404099a6ed@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox