mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: perachet7@gmail.com
To: barebox@lists.infradead.org
Subject: [PATCH 1/1] rk3188: don't set same clk rate twice
Date: Thu, 08 Nov 2018 15:34:29 +0100	[thread overview]
Message-ID: <2337209.lTZxGkHaYR@think-future.de> (raw)

Hi,

We found setting a clock rate which has already been set, rk3188 (radxa rock 
pro) bails out. This is a quick fix only. Underlying situation not (yet) 
investigated: why it is even trying to set it to the same rate again. It 
remains to state that some but not all rrpro boards exhibit this behaviour, no 
other rk3188 boards have been tested.

Signed-off-by: P. Rachet <perachet7@gmail.com>
---
 drivers/clk/rockchip/clk-pll.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/rockchip/clk-pll.c b/drivers/clk/rockchip/clk-pll.c
index f0dc12091..690da4afb 100644
--- a/drivers/clk/rockchip/clk-pll.c
+++ b/drivers/clk/rockchip/clk-pll.c
@@ -164,6 +164,11 @@ static int rockchip_rk3066_pll_set_rate(struct clk *hw, 
unsigned long drate,
  int cur_parent;
  int ret;

+  if (old_rate == drate) {
+    pr_debug("%s: not changing rate, old == new rate (clk/old/new/parent): 
%s/%lu/%lu/%lu\n", __func__, __clk_get_name(hw), old_rate, drate, prate);
+    return 0;
+  }
+
  pr_debug("%s: changing %s from %lu to %lu with a parent rate of %lu\n",
     __func__, __clk_get_name(hw), old_rate, drate, prate);

--
2.17.1



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2018-11-08 14:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 14:34 perachet7 [this message]
2018-11-09  7:18 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2337209.lTZxGkHaYR@think-future.de \
    --to=perachet7@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox