* [PATCH v1 1/2] net: designware: eqos: fix receive issue with external switch
@ 2022-04-07 9:02 Oleksij Rempel
2022-04-07 9:02 ` [PATCH v1 2/2] net: designware: eqos: do not try to talk to not existing PHY Oleksij Rempel
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Oleksij Rempel @ 2022-04-07 9:02 UTC (permalink / raw)
To: barebox; +Cc: Oleksij Rempel
Do not drop packets with error status (CRC error, receive error, watchdog
timeout, or overflow) otherwise we wont be able to receive packets from
a switch with enabled tagging.
In case we have switch with tagging enabled, ingress packets will be
modified by the switch. Most probably this will affect CRC calculation,
so all incoming packets are dropped.
Setting FEP and FUP is recommended programming model described in
STM32MP157 reference manual. See "64.9.2 MTL initialization":
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/designware_eqos.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/designware_eqos.c b/drivers/net/designware_eqos.c
index 8d2a21c220..1f97d84880 100644
--- a/drivers/net/designware_eqos.c
+++ b/drivers/net/designware_eqos.c
@@ -112,6 +112,8 @@ struct eqos_mtl_regs {
#define EQOS_MTL_RXQ0_OPERATION_MODE_RFA_MASK 0x3f
#define EQOS_MTL_RXQ0_OPERATION_MODE_EHFC BIT(7)
#define EQOS_MTL_RXQ0_OPERATION_MODE_RSF BIT(5)
+#define EQOS_MTL_RXQ0_OPERATION_MODE_FEP BIT(4)
+#define EQOS_MTL_RXQ0_OPERATION_MODE_FUP BIT(3)
#define EQOS_MTL_RXQ0_DEBUG_PRXQ_SHIFT 16
#define EQOS_MTL_RXQ0_DEBUG_PRXQ_MASK 0x7fff
@@ -433,7 +435,9 @@ static int eqos_start(struct eth_device *edev)
/* Enable Store and Forward mode for RX, since no jumbo frame */
setbits_le32(&eqos->mtl_regs->rxq0_operation_mode,
- EQOS_MTL_RXQ0_OPERATION_MODE_RSF);
+ EQOS_MTL_RXQ0_OPERATION_MODE_RSF |
+ EQOS_MTL_RXQ0_OPERATION_MODE_FEP |
+ EQOS_MTL_RXQ0_OPERATION_MODE_FUP);
/* Transmit/Receive queue fifo size; use all RAM for 1 queue */
val = readl(&eqos->mac_regs->hw_feature1);
--
2.30.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v1 2/2] net: designware: eqos: do not try to talk to not existing PHY
2022-04-07 9:02 [PATCH v1 1/2] net: designware: eqos: fix receive issue with external switch Oleksij Rempel
@ 2022-04-07 9:02 ` Oleksij Rempel
2022-04-07 12:23 ` Ahmad Fatoum
2022-04-07 12:23 ` [PATCH v1 1/2] net: designware: eqos: fix receive issue with external switch Ahmad Fatoum
2022-04-12 8:55 ` Sascha Hauer
2 siblings, 1 reply; 6+ messages in thread
From: Oleksij Rempel @ 2022-04-07 9:02 UTC (permalink / raw)
To: barebox; +Cc: Rouven Czerwinski, Oleksij Rempel
From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Currently barebox will try to talk to the phy over mdio, even if the
parent is a fixed-link. This will result in the following stacktrace:
barebox@Linux Automation Test Automation Controller (TAC):/ dhcp
unable to handle NULL pointer dereference at address 0x00000130
pc : [<dfc01800>] lr : [<dfc0f963>]
sp : dffefd40 ip : 004c4b40 fp : d00286e0
r10: cf25cc4e r9 : 00000000 r8 : 05f5e100
r7 : 00000130 r6 : 00000000 r5 : 00000000 r4 : 00000130
r3 : 00000109 r2 : 00000000 r1 : 00000000 r0 : 00000130
Flags: nZCv IRQs off FIQs off Mode SVC_32
WARNING: [<dfc01800>] (slice_acquire+0xc/0x28) from [<dfc0f963>] (mdiobus_read+0x13/0x28)
WARNING: [<dfc0f963>] (mdiobus_read+0x13/0x28) from [<dfc10685>] (eqos_start+0x85/0x32c)
WARNING: [<dfc10685>] (eqos_start+0x85/0x32c) from [<dfc3cdf1>] (eth_open+0xd/0x24)
WARNING: [<dfc3cdf1>] (eth_open+0xd/0x24) from [<dfc3e391>] (dhcp+0xb/0x3a)
WARNING: [<dfc3e391>] (dhcp+0xb/0x3a) from [<dfc30fab>] (do_dhcp+0xfb/0x114)
WARNING: [<dfc30fab>] (do_dhcp+0xfb/0x114) from [<dfc0490f>] (execute_command+0x23/0x4c)
WARNING: [<dfc0490f>] (execute_command+0x23/0x4c) from [<dfc0a127>] (run_list_real+0x5bf/0x638)
WARNING: [<dfc0a127>] (run_list_real+0x5bf/0x638) from [<dfc09a2b>] (parse_stream_outer+0xc7/0x154)
WARNING: [<dfc09a2b>] (parse_stream_outer+0xc7/0x154) from [<dfc0a383>] (run_shell+0x3f/0x6c)
WARNING: [<dfc0a383>] (run_shell+0x3f/0x6c) from [<dfc010b9>] (run_init+0x191/0x200)
WARNING: [<dfc010b9>] (run_init+0x191/0x200) from [<dfc01153>] (start_barebox+0x2b/0x6c)
WARNING: [<dfc01153>] (start_barebox+0x2b/0x6c) from [<dfc4be6d>] (barebox_non_pbl_start+0x121/0x164)
WARNING: [<dfc4be6d>] (barebox_non_pbl_start+0x121/0x164) from [<dfc00005>] (__bare_init_start+0x1/0xc)
WARNING: [<dfc4da7d>] (unwind_backtrace+0x1/0x78) from [<dfc01461>] (panic+0x1d/0x34)
WARNING: [<dfc01461>] (panic+0x1d/0x34) from [<dfc4b6a3>] (do_exception+0xf/0x14)
WARNING: [<dfc4b6a3>] (do_exception+0xf/0x14) from [<dfc4b711>] (do_data_abort+0x21/0x34)
WARNING: [<dfc4b711>] (do_data_abort+0x21/0x34) from [<dfc4b454>] (do_abort_6+0x48/0x54)
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/designware_eqos.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/designware_eqos.c b/drivers/net/designware_eqos.c
index 1f97d84880..6b372e4274 100644
--- a/drivers/net/designware_eqos.c
+++ b/drivers/net/designware_eqos.c
@@ -417,9 +417,11 @@ static int eqos_start(struct eth_device *edev)
/* Before we reset the mac, we must insure the PHY is not powered down
* as the dw controller needs all clock domains to be running, including
* the PHY clock, to come out of a mac reset. */
- ret = phy_resume(edev->phydev);
- if (ret)
- return ret;
+ if (edev->phydev) {
+ ret = phy_resume(edev->phydev);
+ if (ret)
+ return ret;
+ }
/* Configure MTL */
--
2.30.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1 2/2] net: designware: eqos: do not try to talk to not existing PHY
2022-04-07 9:02 ` [PATCH v1 2/2] net: designware: eqos: do not try to talk to not existing PHY Oleksij Rempel
@ 2022-04-07 12:23 ` Ahmad Fatoum
2022-04-07 12:39 ` Oleksij Rempel
0 siblings, 1 reply; 6+ messages in thread
From: Ahmad Fatoum @ 2022-04-07 12:23 UTC (permalink / raw)
To: Oleksij Rempel, barebox; +Cc: Rouven Czerwinski
Hello Oleksij,
On 07.04.22 11:02, Oleksij Rempel wrote:
> From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
>
> Currently barebox will try to talk to the phy over mdio, even if the
> parent is a fixed-link. This will result in the following stacktrace:
Is this not covered by Rouven's 6269556397ed ("net: eqos: let phy_resume
handle fixed link phys")?
Cheers,
Ahmad
>
> barebox@Linux Automation Test Automation Controller (TAC):/ dhcp
> unable to handle NULL pointer dereference at address 0x00000130
> pc : [<dfc01800>] lr : [<dfc0f963>]
> sp : dffefd40 ip : 004c4b40 fp : d00286e0
> r10: cf25cc4e r9 : 00000000 r8 : 05f5e100
> r7 : 00000130 r6 : 00000000 r5 : 00000000 r4 : 00000130
> r3 : 00000109 r2 : 00000000 r1 : 00000000 r0 : 00000130
> Flags: nZCv IRQs off FIQs off Mode SVC_32
> WARNING: [<dfc01800>] (slice_acquire+0xc/0x28) from [<dfc0f963>] (mdiobus_read+0x13/0x28)
> WARNING: [<dfc0f963>] (mdiobus_read+0x13/0x28) from [<dfc10685>] (eqos_start+0x85/0x32c)
> WARNING: [<dfc10685>] (eqos_start+0x85/0x32c) from [<dfc3cdf1>] (eth_open+0xd/0x24)
> WARNING: [<dfc3cdf1>] (eth_open+0xd/0x24) from [<dfc3e391>] (dhcp+0xb/0x3a)
> WARNING: [<dfc3e391>] (dhcp+0xb/0x3a) from [<dfc30fab>] (do_dhcp+0xfb/0x114)
> WARNING: [<dfc30fab>] (do_dhcp+0xfb/0x114) from [<dfc0490f>] (execute_command+0x23/0x4c)
> WARNING: [<dfc0490f>] (execute_command+0x23/0x4c) from [<dfc0a127>] (run_list_real+0x5bf/0x638)
> WARNING: [<dfc0a127>] (run_list_real+0x5bf/0x638) from [<dfc09a2b>] (parse_stream_outer+0xc7/0x154)
> WARNING: [<dfc09a2b>] (parse_stream_outer+0xc7/0x154) from [<dfc0a383>] (run_shell+0x3f/0x6c)
> WARNING: [<dfc0a383>] (run_shell+0x3f/0x6c) from [<dfc010b9>] (run_init+0x191/0x200)
> WARNING: [<dfc010b9>] (run_init+0x191/0x200) from [<dfc01153>] (start_barebox+0x2b/0x6c)
> WARNING: [<dfc01153>] (start_barebox+0x2b/0x6c) from [<dfc4be6d>] (barebox_non_pbl_start+0x121/0x164)
> WARNING: [<dfc4be6d>] (barebox_non_pbl_start+0x121/0x164) from [<dfc00005>] (__bare_init_start+0x1/0xc)
>
> WARNING: [<dfc4da7d>] (unwind_backtrace+0x1/0x78) from [<dfc01461>] (panic+0x1d/0x34)
> WARNING: [<dfc01461>] (panic+0x1d/0x34) from [<dfc4b6a3>] (do_exception+0xf/0x14)
> WARNING: [<dfc4b6a3>] (do_exception+0xf/0x14) from [<dfc4b711>] (do_data_abort+0x21/0x34)
> WARNING: [<dfc4b711>] (do_data_abort+0x21/0x34) from [<dfc4b454>] (do_abort_6+0x48/0x54)
>
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/net/designware_eqos.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/designware_eqos.c b/drivers/net/designware_eqos.c
> index 1f97d84880..6b372e4274 100644
> --- a/drivers/net/designware_eqos.c
> +++ b/drivers/net/designware_eqos.c
> @@ -417,9 +417,11 @@ static int eqos_start(struct eth_device *edev)
> /* Before we reset the mac, we must insure the PHY is not powered down
> * as the dw controller needs all clock domains to be running, including
> * the PHY clock, to come out of a mac reset. */
> - ret = phy_resume(edev->phydev);
> - if (ret)
> - return ret;
> + if (edev->phydev) {
> + ret = phy_resume(edev->phydev);
> + if (ret)
> + return ret;
> + }
>
> /* Configure MTL */
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1 2/2] net: designware: eqos: do not try to talk to not existing PHY
2022-04-07 12:23 ` Ahmad Fatoum
@ 2022-04-07 12:39 ` Oleksij Rempel
0 siblings, 0 replies; 6+ messages in thread
From: Oleksij Rempel @ 2022-04-07 12:39 UTC (permalink / raw)
To: Ahmad Fatoum; +Cc: barebox, Rouven Czerwinski
On Thu, Apr 07, 2022 at 02:23:04PM +0200, Ahmad Fatoum wrote:
> Hello Oleksij,
>
> On 07.04.22 11:02, Oleksij Rempel wrote:
> > From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> >
> > Currently barebox will try to talk to the phy over mdio, even if the
> > parent is a fixed-link. This will result in the following stacktrace:
>
> Is this not covered by Rouven's 6269556397ed ("net: eqos: let phy_resume
> handle fixed link phys")?
Yes, you right. Please ignore this patch.
> >
> > barebox@Linux Automation Test Automation Controller (TAC):/ dhcp
> > unable to handle NULL pointer dereference at address 0x00000130
> > pc : [<dfc01800>] lr : [<dfc0f963>]
> > sp : dffefd40 ip : 004c4b40 fp : d00286e0
> > r10: cf25cc4e r9 : 00000000 r8 : 05f5e100
> > r7 : 00000130 r6 : 00000000 r5 : 00000000 r4 : 00000130
> > r3 : 00000109 r2 : 00000000 r1 : 00000000 r0 : 00000130
> > Flags: nZCv IRQs off FIQs off Mode SVC_32
> > WARNING: [<dfc01800>] (slice_acquire+0xc/0x28) from [<dfc0f963>] (mdiobus_read+0x13/0x28)
> > WARNING: [<dfc0f963>] (mdiobus_read+0x13/0x28) from [<dfc10685>] (eqos_start+0x85/0x32c)
> > WARNING: [<dfc10685>] (eqos_start+0x85/0x32c) from [<dfc3cdf1>] (eth_open+0xd/0x24)
> > WARNING: [<dfc3cdf1>] (eth_open+0xd/0x24) from [<dfc3e391>] (dhcp+0xb/0x3a)
> > WARNING: [<dfc3e391>] (dhcp+0xb/0x3a) from [<dfc30fab>] (do_dhcp+0xfb/0x114)
> > WARNING: [<dfc30fab>] (do_dhcp+0xfb/0x114) from [<dfc0490f>] (execute_command+0x23/0x4c)
> > WARNING: [<dfc0490f>] (execute_command+0x23/0x4c) from [<dfc0a127>] (run_list_real+0x5bf/0x638)
> > WARNING: [<dfc0a127>] (run_list_real+0x5bf/0x638) from [<dfc09a2b>] (parse_stream_outer+0xc7/0x154)
> > WARNING: [<dfc09a2b>] (parse_stream_outer+0xc7/0x154) from [<dfc0a383>] (run_shell+0x3f/0x6c)
> > WARNING: [<dfc0a383>] (run_shell+0x3f/0x6c) from [<dfc010b9>] (run_init+0x191/0x200)
> > WARNING: [<dfc010b9>] (run_init+0x191/0x200) from [<dfc01153>] (start_barebox+0x2b/0x6c)
> > WARNING: [<dfc01153>] (start_barebox+0x2b/0x6c) from [<dfc4be6d>] (barebox_non_pbl_start+0x121/0x164)
> > WARNING: [<dfc4be6d>] (barebox_non_pbl_start+0x121/0x164) from [<dfc00005>] (__bare_init_start+0x1/0xc)
> >
> > WARNING: [<dfc4da7d>] (unwind_backtrace+0x1/0x78) from [<dfc01461>] (panic+0x1d/0x34)
> > WARNING: [<dfc01461>] (panic+0x1d/0x34) from [<dfc4b6a3>] (do_exception+0xf/0x14)
> > WARNING: [<dfc4b6a3>] (do_exception+0xf/0x14) from [<dfc4b711>] (do_data_abort+0x21/0x34)
> > WARNING: [<dfc4b711>] (do_data_abort+0x21/0x34) from [<dfc4b454>] (do_abort_6+0x48/0x54)
> >
> > Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > drivers/net/designware_eqos.c | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/designware_eqos.c b/drivers/net/designware_eqos.c
> > index 1f97d84880..6b372e4274 100644
> > --- a/drivers/net/designware_eqos.c
> > +++ b/drivers/net/designware_eqos.c
> > @@ -417,9 +417,11 @@ static int eqos_start(struct eth_device *edev)
> > /* Before we reset the mac, we must insure the PHY is not powered down
> > * as the dw controller needs all clock domains to be running, including
> > * the PHY clock, to come out of a mac reset. */
> > - ret = phy_resume(edev->phydev);
> > - if (ret)
> > - return ret;
> > + if (edev->phydev) {
> > + ret = phy_resume(edev->phydev);
> > + if (ret)
> > + return ret;
> > + }
> >
> > /* Configure MTL */
> >
>
>
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 1/2] net: designware: eqos: fix receive issue with external switch
2022-04-07 9:02 [PATCH v1 1/2] net: designware: eqos: fix receive issue with external switch Oleksij Rempel
2022-04-07 9:02 ` [PATCH v1 2/2] net: designware: eqos: do not try to talk to not existing PHY Oleksij Rempel
@ 2022-04-07 12:23 ` Ahmad Fatoum
2022-04-12 8:55 ` Sascha Hauer
2 siblings, 0 replies; 6+ messages in thread
From: Ahmad Fatoum @ 2022-04-07 12:23 UTC (permalink / raw)
To: Oleksij Rempel, barebox
On 07.04.22 11:02, Oleksij Rempel wrote:
> Do not drop packets with error status (CRC error, receive error, watchdog
> timeout, or overflow) otherwise we wont be able to receive packets from
> a switch with enabled tagging.
>
> In case we have switch with tagging enabled, ingress packets will be
> modified by the switch. Most probably this will affect CRC calculation,
> so all incoming packets are dropped.
>
> Setting FEP and FUP is recommended programming model described in
> STM32MP157 reference manual. See "64.9.2 MTL initialization":
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/net/designware_eqos.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/designware_eqos.c b/drivers/net/designware_eqos.c
> index 8d2a21c220..1f97d84880 100644
> --- a/drivers/net/designware_eqos.c
> +++ b/drivers/net/designware_eqos.c
> @@ -112,6 +112,8 @@ struct eqos_mtl_regs {
> #define EQOS_MTL_RXQ0_OPERATION_MODE_RFA_MASK 0x3f
> #define EQOS_MTL_RXQ0_OPERATION_MODE_EHFC BIT(7)
> #define EQOS_MTL_RXQ0_OPERATION_MODE_RSF BIT(5)
> +#define EQOS_MTL_RXQ0_OPERATION_MODE_FEP BIT(4)
> +#define EQOS_MTL_RXQ0_OPERATION_MODE_FUP BIT(3)
>
> #define EQOS_MTL_RXQ0_DEBUG_PRXQ_SHIFT 16
> #define EQOS_MTL_RXQ0_DEBUG_PRXQ_MASK 0x7fff
> @@ -433,7 +435,9 @@ static int eqos_start(struct eth_device *edev)
>
> /* Enable Store and Forward mode for RX, since no jumbo frame */
> setbits_le32(&eqos->mtl_regs->rxq0_operation_mode,
> - EQOS_MTL_RXQ0_OPERATION_MODE_RSF);
> + EQOS_MTL_RXQ0_OPERATION_MODE_RSF |
> + EQOS_MTL_RXQ0_OPERATION_MODE_FEP |
> + EQOS_MTL_RXQ0_OPERATION_MODE_FUP);
>
> /* Transmit/Receive queue fifo size; use all RAM for 1 queue */
> val = readl(&eqos->mac_regs->hw_feature1);
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1 1/2] net: designware: eqos: fix receive issue with external switch
2022-04-07 9:02 [PATCH v1 1/2] net: designware: eqos: fix receive issue with external switch Oleksij Rempel
2022-04-07 9:02 ` [PATCH v1 2/2] net: designware: eqos: do not try to talk to not existing PHY Oleksij Rempel
2022-04-07 12:23 ` [PATCH v1 1/2] net: designware: eqos: fix receive issue with external switch Ahmad Fatoum
@ 2022-04-12 8:55 ` Sascha Hauer
2 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2022-04-12 8:55 UTC (permalink / raw)
To: Oleksij Rempel; +Cc: barebox
On Thu, Apr 07, 2022 at 11:02:45AM +0200, Oleksij Rempel wrote:
> Do not drop packets with error status (CRC error, receive error, watchdog
> timeout, or overflow) otherwise we wont be able to receive packets from
> a switch with enabled tagging.
>
> In case we have switch with tagging enabled, ingress packets will be
> modified by the switch. Most probably this will affect CRC calculation,
> so all incoming packets are dropped.
>
> Setting FEP and FUP is recommended programming model described in
> STM32MP157 reference manual. See "64.9.2 MTL initialization":
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/net/designware_eqos.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/designware_eqos.c b/drivers/net/designware_eqos.c
> index 8d2a21c220..1f97d84880 100644
> --- a/drivers/net/designware_eqos.c
> +++ b/drivers/net/designware_eqos.c
> @@ -112,6 +112,8 @@ struct eqos_mtl_regs {
> #define EQOS_MTL_RXQ0_OPERATION_MODE_RFA_MASK 0x3f
> #define EQOS_MTL_RXQ0_OPERATION_MODE_EHFC BIT(7)
> #define EQOS_MTL_RXQ0_OPERATION_MODE_RSF BIT(5)
> +#define EQOS_MTL_RXQ0_OPERATION_MODE_FEP BIT(4)
> +#define EQOS_MTL_RXQ0_OPERATION_MODE_FUP BIT(3)
>
> #define EQOS_MTL_RXQ0_DEBUG_PRXQ_SHIFT 16
> #define EQOS_MTL_RXQ0_DEBUG_PRXQ_MASK 0x7fff
> @@ -433,7 +435,9 @@ static int eqos_start(struct eth_device *edev)
>
> /* Enable Store and Forward mode for RX, since no jumbo frame */
> setbits_le32(&eqos->mtl_regs->rxq0_operation_mode,
> - EQOS_MTL_RXQ0_OPERATION_MODE_RSF);
> + EQOS_MTL_RXQ0_OPERATION_MODE_RSF |
> + EQOS_MTL_RXQ0_OPERATION_MODE_FEP |
> + EQOS_MTL_RXQ0_OPERATION_MODE_FUP);
>
> /* Transmit/Receive queue fifo size; use all RAM for 1 queue */
> val = readl(&eqos->mac_regs->hw_feature1);
> --
> 2.30.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-12 8:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 9:02 [PATCH v1 1/2] net: designware: eqos: fix receive issue with external switch Oleksij Rempel
2022-04-07 9:02 ` [PATCH v1 2/2] net: designware: eqos: do not try to talk to not existing PHY Oleksij Rempel
2022-04-07 12:23 ` Ahmad Fatoum
2022-04-07 12:39 ` Oleksij Rempel
2022-04-07 12:23 ` [PATCH v1 1/2] net: designware: eqos: fix receive issue with external switch Ahmad Fatoum
2022-04-12 8:55 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox