mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>, barebox@lists.infradead.org
Cc: Fabian Pflug <f.pflug@pengutronix.de>
Subject: Re: [PATCH] defaultenv: don't pass environment path to zero env
Date: Wed, 2 Sep 2026 10:45:36 +0200	[thread overview]
Message-ID: <27d45798-6876-4e70-b2e0-9ddcf3f9a732@pengutronix.de> (raw)
In-Reply-To: <178833859741.3676557.11754066543148243970.b4-ty@pengutronix.de>

Hello Sascha,

On 9/2/26 10:43 AM, Sascha Hauer wrote:
> 
> On Tue, 01 Sep 2026 14:28:31 +0200, Ahmad Fatoum wrote:
>> bareboxenv -z sets ENVFS_FLAGS_FORCE_BUILT_IN, which makes envfs_save()
>> emit a bare header and never look at its directory argument. Passing
>> CONFIG_DEFAULT_ENVIRONMENT_PATH there was pointless, but harmless until
>> the Kconfig sync made auto.conf no longer quote string options:
>> The result is that the quotes became part of the value.
>>
>> This is triggered by OpenEmbedded's barebox.bbclass for example, which
>> overrides the option on the make command line in the old, quoted form:
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] defaultenv: don't pass environment path to zero env
>       https://git.pengutronix.de/cgit/barebox/commit/?id=be574e455b3a (link may not be stable)

Please also backport to master.

Thanks,
Ahmad

> 
> Best regards,

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2026-09-02  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 12:28 Ahmad Fatoum
2026-09-02  8:43 ` Sascha Hauer
2026-09-02  8:45   ` Ahmad Fatoum [this message]
2026-09-02  8:53     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27d45798-6876-4e70-b2e0-9ddcf3f9a732@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=f.pflug@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox