Re: [PATCH v1 1/2] add device state flags and add error state

[Bartosz Bilas <b.bilas@grinn-global.com>]

Hello,

On 21.06.2021 10:07, Ahmad Fatoum wrote:
> On 06.06.21 14:23, Oleksij Rempel wrote:
>> Add state flags for each registered device and set error state on each
>> dev_err print.
>> This states can be used by users to identify erroneous device.
> I thought this over a bit. We have dev_err calls when:
>   
>   - probes are permanently deferred
>   - have actual probe (!= -ENODEV, != -ENXIO, != -EPROBE_DEFER)
>   - after probe something fails (e.g. you got the regulator, but couldn't enable it)
>
> So, I think the hook point is appropriate. Board code could extend this
> and get a device and do some extra tests and use dev_set_err as appropriate.
>
> So feel free to add:
>
> Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>> ---
>>   include/driver.h | 13 +++++++++++++
>>   include/printk.h |  5 ++++-
>>   2 files changed, 17 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/driver.h b/include/driver.h
>> index d84fe35d50..b64a8e258c 100644
>> --- a/include/driver.h
>> +++ b/include/driver.h
>> @@ -88,6 +88,9 @@ struct device_d {
>>   	 * when the driver should actually detect client devices
>>   	 */
>>   	int     (*detect) (struct device_d *);
>> +
>> +#define DEV_ERR			BIT(0)
>> +	u32	run_flags;
> Just turn it into a bit field instead?
>
>>   };
>>   
>>   /** @brief Describes a driver present in the system */
>> @@ -361,6 +364,16 @@ static inline int dev_close_default(struct device_d *dev, struct filep *f)
>>   	return 0;
>>   }
>>   
>> +static inline void dev_set_err(struct device_d *dev)
>> +{
>> +	dev->run_flags |= DEV_ERR;
>> +}
>> +
>> +static inline bool dev_have_err(struct device_d *dev)
>> +{
>> +	return !!(dev->run_flags & DEV_ERR);

Isn't return dev->run_flags & DEV_ERR enough here?

Best
Bartek
>> +}
>> +
>>   struct bus_type {
>>   	char *name;
>>   	int (*match)(struct device_d *dev, struct driver_d *drv);
>> diff --git a/include/printk.h b/include/printk.h
>> index f83ad3bf07..6c563be3e6 100644
>> --- a/include/printk.h
>> +++ b/include/printk.h
>> @@ -61,7 +61,10 @@ static inline int pr_print(int level, const char *format, ...)
>>   #define dev_crit(dev, format, arg...)		\
>>   	__dev_printf(2, (dev) , format , ## arg)
>>   #define dev_err(dev, format, arg...)		\
>> -	__dev_printf(3, (dev) , format , ## arg)
>> +	({ \
> You're already using statement expressions, so you could add a
> 		struct device_d *__dev = (dev);
> here and use that.
>
>> +		dev_set_err(dev); \
>> +		__dev_printf(3, (dev) , format , ## arg); \
>> +	})
>>   #define dev_warn(dev, format, arg...)		\
>>   	__dev_printf(4, (dev) , format , ## arg)
>>   #define dev_notice(dev, format, arg...)		\
>>

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox