From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gk3yS-0007wl-4c for barebox@lists.infradead.org; Thu, 17 Jan 2019 09:28:39 +0000 References: <20190116174559.17416-1-a.fatoum@pengutronix.de> <20190116174559.17416-8-a.fatoum@pengutronix.de> <20190117081136.lkoso5bwrrt34ga3@pengutronix.de> From: Ahmad Fatoum Message-ID: <28ea8268-ebb3-f7e6-4006-1b02f72963a1@pengutronix.de> Date: Thu, 17 Jan 2019 10:28:30 +0100 MIME-Version: 1.0 In-Reply-To: <20190117081136.lkoso5bwrrt34ga3@pengutronix.de> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 07/11] ARM: at91: import low level DDRAMC initialization code from at91bootstrap To: Sascha Hauer Cc: barebox@lists.infradead.org On 17/1/19 09:11, Sascha Hauer wrote: > On Wed, Jan 16, 2019 at 06:45:55PM +0100, Ahmad Fatoum wrote: >> This commit imports DDRAMC initialization routines for use in PBL from >> https://github.com/linux4sam/at91bootstrap/blob/v3.8.12/driver/ddramc.c >> >> Signed-off-by: Ahmad Fatoum >> --- >> + >> +void ddram_initialize(unsigned long base_address, >> + unsigned long ram_address, >> + struct ddramc_register *ddramc_config) > > All the exported functions should have a proper at91_ or whatever > prefix. > > Sascha > > Will do in v2. Thanks Ahmad -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox