From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] clk: at91: fix compilation errors in sama5d2.c
Date: Thu, 23 May 2019 16:09:37 +0200 [thread overview]
Message-ID: <29502fd0-597b-04b9-2087-cad8595051ee@pengutronix.de> (raw)
In-Reply-To: <20190402171024.GB7902@ravnborg.org>
Hello Sam,
On 2/4/19 19:10, Sam Ravnborg wrote:
> Hi Ahmad.
>
> Thanks for looking into this.
>
> On Mon, Apr 01, 2019 at 12:32:57PM +0200, Ahmad Fatoum wrote:
>> sama5d2 was added along with the update to the upstream
>> device tree bindings, but wasn't wired in anywhere.
>>
>> To prepare for usage in future sama5d2 support, fix
>> compilation errors related to absence of locks and
>> unavailability of audio/i2s clock/pll handling.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
> Another approach could have been to stub out the
> non-existing functions to make diff between the kernel
> and the barebox variant smaller.
>
> Did you consider that approach?
Originally, I only thought about returning -ENOSYS from stubs,
but that won't work because the function would then fail.
I didn't think of returning NULL instead though..
But returning NULL from the stubs won't work for the hunk
at the bottom (the one guarded by if (regmap_sfr)).
That would cause NULL 'holes' in the array and of_clk_get_from_provider,
which normally never returns NULL could start returning NULL then.
I don't want to audit whether that's ok, so I prefer the route of just
removing the audio/i2s stuff...
>
> The whole section in CONFIG_HAVE_AT91_AUDIO_PLL in dt-compat.c
> is also something we could drop btw. if we go the "drop all audio" stuff
> from clk. Also prototypes in pmc.h
Indeed, thanks for spotting that and sorry for the late answer.
I haven't had time to look at this since then.
Cheers
Ahmad
>
> The patch itself looked fine. But I think that from a maintenance point of
> view should stub us out of it.
> Let me know what you think.
>
> Sam
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-05-23 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 10:32 Ahmad Fatoum
2019-04-02 17:10 ` Sam Ravnborg
2019-05-23 14:09 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29502fd0-597b-04b9-2087-cad8595051ee@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox