From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 11 Jan 2024 16:29:23 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rNwzj-00D7OO-1p for lore@lore.pengutronix.de; Thu, 11 Jan 2024 16:29:23 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNwzi-0007v2-W5 for lore@pengutronix.de; Thu, 11 Jan 2024 16:29:23 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4B4uD+TvfD3xiVbLtIvnRwcdV3KIXqgDU+dEELgqzTM=; b=0d5qI9fAjM11FSbmsCpMijVclJ ewSrCdTatcPga4r/O864GZuctAgbyDbkm8SkwQYVv9ry0I+nrgI7Sb3gNvE5v0zSbX2fA/ptnNsz2 UMyKfGhbO4Oe2b+bknfriAWm5Ct4xIhqYrrBarSxrwDlnhE6nFYBr2HgB2wXSXG+ZkpFyz0RF6reF /IO0rc/fIUe++eJTJLTW297rg5IePiKtO+O4QtTtnoUGmlSfa+cL4Pxb1XmwbeONtjG/+Y12PQ7Vj s/uS/mWM8HWbxPq7+clbLsozJ+xDU1r/s0p4slhiHq5EkgUtKZjFiciWx6MuBcL9UiR1cghJ0dFWt eAieu5Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNwyd-000RJ3-1L; Thu, 11 Jan 2024 15:28:15 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNwya-000RFj-1B for barebox@lists.infradead.org; Thu, 11 Jan 2024 15:28:13 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rNwyZ-0007b4-0y; Thu, 11 Jan 2024 16:28:11 +0100 Message-ID: <29599fdb-2977-44a9-901c-4d056dc9cad1@pengutronix.de> Date: Thu, 11 Jan 2024 16:28:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Marco Felsch Cc: barebox@lists.infradead.org References: <20240111114841.2676939-1-m.felsch@pengutronix.de> <20240111114841.2676939-2-m.felsch@pengutronix.de> <5f1325a1-44ec-42ac-9295-f607a624327a@pengutronix.de> <20240111121602.qlcxvtwmghjmmgyb@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20240111121602.qlcxvtwmghjmmgyb@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240111_072812_412210_F9C06E38 X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-6.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 01/18] ARM: i.MX8M: atf: make use of imx8m*_save_bootrom_log macros X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 11.01.24 13:16, Marco Felsch wrote: > On 24-01-11, Ahmad Fatoum wrote: >> On 11.01.24 12:48, Marco Felsch wrote: >>> if (IS_ENABLED(CONFIG_FIRMWARE_IMX8MN_OPTEE)) { >>> @@ -305,9 +305,9 @@ __noreturn void imx8mq_load_and_start_image_via_tfa(void) >>> const void *bl31; >>> size_t bl31_size; >>> void *bl33 = (void *)MX8M_ATF_BL33_BASE_ADDR; >>> - unsigned long endmem = MX8M_DDR_CSD1_BASE_ADDR + imx8m_barebox_earlymem_size(16); >>> + unsigned long endmem = MX8M_DDR_CSD1_BASE_ADDR + imx8m_barebox_earlymem_size(32); >> >> Why this change? > > Because the ddr-bandwidth for i.MX8MQ is 32-bit and the usage of > imx8mq_save_bootrom_log() will fix this as well. Ah, you even mention it in the commit message even. Reviewed-by: Ahmad Fatoum Thanks, Ahmad > > Regards, > Marco > >> >>> >>> - imx8m_save_bootrom_log((void *)arm_mem_scratch(endmem)); >>> + imx8mq_save_bootrom_log(); >>> imx8mq_load_bl33(bl33); >>> >>> if (IS_ENABLED(CONFIG_FIRMWARE_IMX8MQ_OPTEE)) { >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |