mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Geordan Neukum <gneukum1@gmail.com>, barebox@lists.infradead.org
Cc: abbotti@mev.co.uk, u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH v2] LICENSES: modify .gitignore files to be nonempty
Date: Tue, 14 May 2019 13:00:48 +0200	[thread overview]
Message-ID: <305f7591-9491-d9f7-d583-6acfc0989720@pengutronix.de> (raw)
In-Reply-To: <20190514103713.3849-1-gneukum1@gmail.com>

On 14/5/19 12:37, Geordan Neukum wrote:
> The .gitignore files under the LICENSES/exceptions and LICENSES/other
> directories cannot have a size of 0 or else they are subject to removal
> by the make target 'distclean'. Modify the .gitignore files to
> ignore all files except for themselves. This shall serve as a reminder
> that these .gitignores can and should be removed when new licenses are
> added.
> 
> Signed-off-by: Geordan Neukum <gneukum1@gmail.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
> Changes in v2: 
> - Added whitespace for readability's sake
> - Modified comment to specify intent more clearly 
>  
>  LICENSES/exceptions/.gitignore | 8 ++++++++
>  LICENSES/other/.gitignore      | 8 ++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/LICENSES/exceptions/.gitignore b/LICENSES/exceptions/.gitignore
> index e69de29bb..7323b9e1a 100644
> --- a/LICENSES/exceptions/.gitignore
> +++ b/LICENSES/exceptions/.gitignore
> @@ -0,0 +1,8 @@
> +# Placeholder as upstream checkpatch.pl requires this directory to exist
> +# This file can be removed when new files are added
> +
> +# Ignore everything in this directory
> +*
> +
> +# Except for this file
> +!.gitignore
> diff --git a/LICENSES/other/.gitignore b/LICENSES/other/.gitignore
> index e69de29bb..7323b9e1a 100644
> --- a/LICENSES/other/.gitignore
> +++ b/LICENSES/other/.gitignore
> @@ -0,0 +1,8 @@
> +# Placeholder as upstream checkpatch.pl requires this directory to exist
> +# This file can be removed when new files are added
> +
> +# Ignore everything in this directory
> +*
> +
> +# Except for this file
> +!.gitignore
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-05-14 11:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-12 22:17 distclean removing LICENSES .gitignores Geordan Neukum
2019-05-13 15:05 ` Ahmad Fatoum
2019-05-14  2:19   ` [PATCH] LICENSES: modify .gitignore files to be nonempty Geordan Neukum
2019-05-14  7:28     ` Ian Abbott
2019-05-14  8:28       ` Ahmad Fatoum
2019-05-14 12:51         ` Ian Abbott
2019-05-15  0:45           ` [PATCH v2] " Geordan Neukum
2019-05-15  8:54             ` Ahmad Fatoum
2019-05-15  0:56           ` [PATCH] " Geordan Neukum
2019-05-14  8:35     ` Uwe Kleine-König
2019-05-14 10:37       ` [PATCH v2] " Geordan Neukum
2019-05-14 11:00         ` Ahmad Fatoum [this message]
2019-05-15  7:44   ` distclean removing LICENSES .gitignores Sascha Hauer
2019-05-16  3:53   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=305f7591-9491-d9f7-d583-6acfc0989720@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=abbotti@mev.co.uk \
    --cc=barebox@lists.infradead.org \
    --cc=gneukum1@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox