From: Jonas Rebmann <jre@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/2] fs: move fs_driver operations to struct file_operations
Date: Mon, 13 Oct 2025 13:20:04 +0200 [thread overview]
Message-ID: <3122943d-cc66-492c-b1ec-85d43c45816c@pengutronix.de> (raw)
In-Reply-To: <20251001-fs-remove-dev-argument-v1-2-1922aaf65062@pengutronix.de>
Hi
On 2025-10-01 10:06, Sascha Hauer wrote:
> The fs_driver operations really belong to struct file_operations. Move
> them there and clear a long standing TODO item.
> For the filesystems using the legacy layer move the file_operations to
> the legacy operations.
This patch (applied to next as ee6855706447) breaks CI: test/py/test_fit.py:
> assert of_get_property(barebox, "/chosen/barebox-version") == f'"{ver}"', \
"/chosen/barebox-version suggests we did not chainload"
E AssertionError: /chosen/barebox-version suggests we did not chainload
E assert False == '"barebox-2025.09.0-00109-gee6855706447"'
E + where False = of_get_property(BareboxDriver(target=Target(name='main', env=Environment(config_file='test/arm/virt@multi_v8_defconfig.yaml')), name=N...ebox@[^:]+:[^ ]+ ', autoboot='stop autoboot', interrupt='\n', bootstring='commandline:', password='', login_timeout=60), '/chosen/barebox-version')
test/py/test_fit.py:48: AssertionError
This is for all platforms supporting testfs.
This seems unrelated to CI failing on test_tlv as long as the CI container
hasn't been rebuilt with 9703b653fb09
Regards,
Jonas
--
Pengutronix e.K. | Jonas Rebmann |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
next prev parent reply other threads:[~2025-10-13 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 8:06 [PATCH 0/2] fs: remove dev argument from file operations Sascha Hauer
2025-10-01 8:06 ` [PATCH 1/2] fs: remove redundant dev argument from fs_driver operations Sascha Hauer
2025-10-01 8:06 ` [PATCH 2/2] fs: move fs_driver operations to struct file_operations Sascha Hauer
2025-10-13 11:20 ` Jonas Rebmann [this message]
2025-10-07 12:01 ` [PATCH 0/2] fs: remove dev argument from file operations Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3122943d-cc66-492c-b1ec-85d43c45816c@pengutronix.de \
--to=jre@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox