mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/4] commands: hab: check for error in imx_hab_device_locked_down
@ 2023-07-26 19:27 Ahmad Fatoum
  2023-07-26 19:27 ` [PATCH 2/4] HAB: guard against NULL imx_hab_ops in imx_hab_device_locked_down() Ahmad Fatoum
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Ahmad Fatoum @ 2023-07-26 19:27 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

imx_hab_device_locked_down() reads efuses and that operation can fail.
Instead of assuming a failure means the efuses are non-zero, have the
hab command explicitly check for negative error codes.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 commands/hab.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/commands/hab.c b/commands/hab.c
index 97a1701fa551..8ae943a4c880 100644
--- a/commands/hab.c
+++ b/commands/hab.c
@@ -58,7 +58,13 @@ static int do_hab(int argc, char *argv[])
 			printf("%02x", srk[i]);
 		printf("\n");
 
-		if (imx_hab_device_locked_down())
+		ret = imx_hab_device_locked_down();
+		if (ret < 0) {
+			printf("failed to determine lockdown mode: '%pe'\n", ERR_PTR(ret));
+			return ret;
+		}
+
+		if (ret)
 			printf("secure mode\n");
 		else
 			printf("devel mode\n");
-- 
2.39.2




^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-07-28  6:10 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26 19:27 [PATCH 1/4] commands: hab: check for error in imx_hab_device_locked_down Ahmad Fatoum
2023-07-26 19:27 ` [PATCH 2/4] HAB: guard against NULL imx_hab_ops in imx_hab_device_locked_down() Ahmad Fatoum
2023-07-26 19:27 ` [PATCH 3/4] nvmem: ocotp: handle too early calls into ocotp driver gracefully Ahmad Fatoum
2023-07-27  6:05   ` Marco Felsch
2023-07-27  6:26     ` Ahmad Fatoum
2023-07-26 19:27 ` [PATCH 4/4] hab: habv4: export function to query HAB state Ahmad Fatoum
2023-07-27  6:05 ` [PATCH 1/4] commands: hab: check for error in imx_hab_device_locked_down Marco Felsch
2023-07-28  6:09 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox