From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 05 May 2023 09:58:15 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1puqKW-005e67-9v for lore@lore.pengutronix.de; Fri, 05 May 2023 09:58:15 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puqKU-0003rG-Di for lore@pengutronix.de; Fri, 05 May 2023 09:58:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xNpPzmDoHIHoyQYWO2lM0a3G9nJnH/fP/0YkqI2vL0s=; b=cv37Oo2QivwgY6l23zk/CL1zkG vxi2cgiOGYkezFZFvvefHiGS29YQhTslvnBHIGxb0qKdGitBJumh7knXSkTdhS+9v+BjI6a+wssrP +DhUSQutTDIBc4CU2obr4ONlNDfBY8DQfpHkZZpbQj7EvTs8qxrbmcH2b2jVqrjpL7+BuAufwXN/T Eaq2PX62Pan2s7vVNsZneADLZNoNpCzuw1KL7hHpFs0qvLW9D/4dA6vSxO4nEXLqHrr5U2i9eWCmV oglWWIPBU2L9nzMmNhOBkJ1lcg42bi+orLzB1r/ezm3Xm57XuLduX8CbO2cet7UqcXMcmav4amVVW jyQEgl/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puqJV-009yQk-1z; Fri, 05 May 2023 07:57:13 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puqJI-009yOX-0I for barebox@lists.infradead.org; Fri, 05 May 2023 07:57:11 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1puqJD-0003f7-13; Fri, 05 May 2023 09:56:55 +0200 Message-ID: <32e5a633-8921-0d69-0a1e-03efa8162493@pengutronix.de> Date: Fri, 5 May 2023 09:56:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: Johannes Zink , barebox@lists.infradead.org Cc: kernel@pengutronix.de, patchwork-jzi@pengutronix.de References: <20230505075308.1015157-1-j.zink@pengutronix.de> <20230505075308.1015157-2-j.zink@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230505075308.1015157-2-j.zink@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230505_005703_076259_25A42269 X-CRM114-Status: GOOD ( 21.97 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-7.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v1 1/3] imx-usb-loader: error with success when displaying help on purpose X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 05.05.23 09:53, Johannes Zink wrote: > Previously, whenever the usage was displayed, the imx-usb-loader exited > with error code. > > When the usage is displayed due to invalid tool invocation, returning an > error code is valid behaviour, but when displaying the usage with the -h > command line option, success should be returned. > > Signed-off-by: Johannes Zink Reviewed-by: Ahmad Fatoum The diff doesn't show that the other usage() callsite has an exit(1) following it. Please note such things in the commit message in the future. > --- > scripts/imx/imx-usb-loader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/imx/imx-usb-loader.c b/scripts/imx/imx-usb-loader.c > index 41d57906c752..17b83b611765 100644 > --- a/scripts/imx/imx-usb-loader.c > +++ b/scripts/imx/imx-usb-loader.c > @@ -1527,7 +1527,6 @@ static void usage(const char *prgname) > "-s skip DCD included in image\n" > "-v verbose (give multiple times to increase)\n" > "-h this help\n", prgname); > - exit(1); > } > > int main(int argc, char *argv[]) > @@ -1558,6 +1557,7 @@ int main(int argc, char *argv[]) > break; > case 'h': > usage(argv[0]); > + exit(0); > case 'd': > devtype = optarg; > break; -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |