From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] watchdog: add option to provide fall-back restart handler
Date: Mon, 31 May 2021 12:17:01 +0200 [thread overview]
Message-ID: <357af9f7-26fe-cb27-e08f-9b6171bd0a2b@pengutronix.de> (raw)
In-Reply-To: <20210531095048.GS5211@pengutronix.de>
Hi,
On 31.05.21 11:50, Sascha Hauer wrote:
> On Mon, May 31, 2021 at 09:13:19AM +0200, Ahmad Fatoum wrote:
>> Some barebox ports may have a watchdog, but no restart handler, e.g.
>> reset happens via PMIC, which has no driver yet, but watchdog controls
>> reset line going to PMIC. Accommodate such setups by allowing
>> registration of watchdog as fall back restart handler.
>>
>> As reset handling can't be disabled, this is made a default n option
>> to conserve binary size unless explicitly enabled.
>
> Do we really need to make this optional? The binary size overhead can't
> be much more than a few bytes.
I wouldn't like, if after an update, reset silently fell back to the
watchdog instead of hanging and alerting the user that something broke.
For development, it's ok, but once I have a proper reset driver, I want
either that or an error message IMO.
Cheers,
Ahmad
>
> Sascha
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2021-05-31 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 7:13 Ahmad Fatoum
2021-05-31 9:50 ` Sascha Hauer
2021-05-31 10:17 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=357af9f7-26fe-cb27-e08f-9b6171bd0a2b@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox