From: "Schenk, Gavin" <G.Schenk@eckelmann.de>
To: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>,
"Götzinger, Jonathan" <J.Goetzinger@eckelmann.de>
Subject: Re: [PATCH] of: fix reproducible node name for legacy vs. new partition binding
Date: Thu, 18 Oct 2018 09:07:59 +0000 [thread overview]
Message-ID: <38931226c1f09227e1fa23b3908a8738ca855cf8.camel@eckelmann.de> (raw)
In-Reply-To: <20181018072356.cnkzl62v4yebvifg@pengutronix.de>
Hi Sascha,
> > 1. [x] of_partition_binding=new in barebox and barebox-state in Linux is working.
> > 2. [ ] set of_partition_binding=legacy in barebox and barebox-state in Linux fails.
> > 3. [x] apply the patch and rebuild and install barebox
> > 4. [x] set of_partition_binding=legacy and barebox-state in Linux is working again \o/.
> >
> > Is this test sufficient?
> > If not what are other usefull testcases?
>
> Thanks for testing.
You are welcome, thanks you for this important patch!
>
> Another test would be if you use the legacy binding in your barebox
> devicetree and then set of_partition_binding=new. Without this patch it
> should fail in Linux and with it it should work. That's the less
> important case though.
>
Understood. Unfortunately I do not have time to test this immediately.
Because state-framework is essential for RAUC and must not break in field, we plan to integrate tests of state-framework
into our jenkins/labgrid. We will try to consider your testcase there.
@Jonathan: If you are back in office please remind me to talk about including this state-framework tests. Feel free to
update the task (or simply implement it :) )
Regards
Gavin
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2018-10-18 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 8:47 Sascha Hauer
2018-10-17 11:07 ` Schenk, Gavin
2018-10-18 7:23 ` s.hauer
2018-10-18 9:07 ` Schenk, Gavin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38931226c1f09227e1fa23b3908a8738ca855cf8.camel@eckelmann.de \
--to=g.schenk@eckelmann.de \
--cc=J.Goetzinger@eckelmann.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox