From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Thorsten Scherer <t.scherer@eckelmann.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/4] video: add MIPI DBI Type C Option 3 support
Date: Thu, 3 Feb 2022 15:34:42 +0100 [thread overview]
Message-ID: <38b06d28-3c74-cb54-afe2-dc643f369d1f@pengutronix.de> (raw)
In-Reply-To: <20220203143052.m2rsapgqzoxelip2@NB142.eckelmann.group>
Hello Thorsten,
On 03.02.22 15:30, Thorsten Scherer wrote:
> Hi Ahmad,
>
> applying this patch makes menuconfig fail.
Yes.
>> +config CMD_MIPI_DBI
>> + bool
>> + depends on DRIVER_VIDEO_MIPI_DBI && SPI
>> + select PRINTF_HEXSTR
>> + prompt "mipi_dbi command"
>> + help
>> + write/read from MIPI DBI SPI device
>> +
>> + Usage: mipi_dbi [-wld] [REG] [DATA...]
>> +
>> + Options:
>> + -l list all MIPI DBI devices
>> + -d DEVICE select specific device (default is first registered)
>> + -w issue write command
>> +
>> +BAREBOX_CMD_START(mipi_dbi)
>> + .cmd = do_mipi_dbi,
>> + BAREBOX_CMD_DESC("write/read from MIPI DBI SPI device")
>> + BAREBOX_CMD_OPTS("[-wld] [REG] [DATA...]")
>> + BAREBOX_CMD_GROUP(CMD_GRP_HWMANIP)
>> + BAREBOX_CMD_HELP(cmd_mipi_dbi_help)
>> +BAREBOX_CMD_END
>
> Copy and paste error?
Ack. I thought the change is so trivial, I don't need to build test..
I sent out a v3 yesteday with this revised, see
https://lore.barebox.org/barebox/20220202223023.341817-1-a.fatoum@pengutronix.de/
Thanks,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2022-02-03 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 9:55 [PATCH 0/4] video: add STM32F429-DISCO video pipeline support Ahmad Fatoum
2022-02-02 9:55 ` [PATCH 1/4] gpiolib: implement gpiod_set_value Ahmad Fatoum
2022-02-02 9:55 ` [PATCH 2/4] video: add driver for STM32 LCD-TFT Display Controller Ahmad Fatoum
2022-02-02 9:55 ` [PATCH 3/4] video: add MIPI DBI Type C Option 3 support Ahmad Fatoum
2022-02-03 14:30 ` Thorsten Scherer
2022-02-03 14:34 ` Ahmad Fatoum [this message]
2022-02-03 14:34 ` Thorsten Scherer
2022-02-03 16:37 ` Ahmad Fatoum
2022-02-02 9:55 ` [PATCH 4/4] video: add Ilitek ILI9341 panel support Ahmad Fatoum
-- strict thread matches above, loose matches on Subject: below --
2022-01-31 8:02 [PATCH 0/4] video: add STM32F429-DISCO video pipeline support Ahmad Fatoum
2022-01-31 8:03 ` [PATCH 3/4] video: add MIPI DBI Type C Option 3 support Ahmad Fatoum
2022-01-31 10:21 ` Sascha Hauer
2022-01-31 10:28 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38b06d28-3c74-cb54-afe2-dc643f369d1f@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=t.scherer@eckelmann.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox