From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fQq0w-00052s-I4 for barebox@lists.infradead.org; Thu, 07 Jun 2018 08:11:24 +0000 References: <1528116451-40149-1-git-send-email-t.remmet@phytec.de> From: Bastian Stender Message-ID: <3b71243d-a672-e895-c30d-974b7f50922d@pengutronix.de> Date: Thu, 7 Jun 2018 10:11:08 +0200 MIME-Version: 1.0 In-Reply-To: <1528116451-40149-1-git-send-email-t.remmet@phytec.de> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] commands: mmc_extcsd: Add support to write multibyte registers To: Teresa Remmet Cc: barebox@lists.infradead.org Hi Teresa, On 06/04/2018 02:47 PM, Teresa Remmet wrote: > It has been possible to write only the first byte of a multibyte register. > Updated the command to write the complete value of a multibyte register at once. > > Signed-off-by: Teresa Remmet > --- > commands/mmc_extcsd.c | 44 +++++++++++++++++++++++++++----------------- > 1 file changed, 27 insertions(+), 17 deletions(-) > > diff --git a/commands/mmc_extcsd.c b/commands/mmc_extcsd.c > index acd23a466bcb..a5af97fbbaf1 100644 > --- a/commands/mmc_extcsd.c > +++ b/commands/mmc_extcsd.c > @@ -2306,10 +2306,8 @@ static int request_write_operation(void) > return 0; > } > > -static void write_field(struct mci *mci, u8 *reg, u16 index, u8 value, > - int always_write) > +int request_one_time_programmable(u16 index) Why do you remove "static" here? > { > - > switch (index) { > case EXT_CSD_BOOT_CONFIG_PROT: > case EXT_CSD_BOOT_WP: > @@ -2349,18 +2347,15 @@ static void write_field(struct mci *mci, u8 *reg, u16 index, u8 value, > case 52: > case EXT_CSD_BARRIER_CTRL: > case EXT_CSD_SECURE_REMOVAL_TYPE: > - if (!always_write) > - if (request_write_operation() == 0) { > - printf("Abort write operation!\n"); > - goto out; > - } > - break; > + if (request_write_operation() == 0) { > + printf("Abort write operation!\n"); > + return 1; > + } else { > + return 0; > + } > } > > - mci_switch(mci, index, value); > - > -out: > - return; > + return 0; > } > > static int do_mmc_extcsd(int argc, char *argv[]) > @@ -2430,11 +2425,26 @@ static int do_mmc_extcsd(int argc, char *argv[]) > if (!print_field(dst, index)) { > printf("No field with this index found. Abort write operation!\n"); > } else { > - write_field(mci, dst, index, value, always_write); > + struct extcsd_reg *ext; > + int i; > + int val = 0; > + > + if (!always_write) { > + retval = request_one_time_programmable(index); > + if (retval) > + goto error_with_mem; > + } > + > + ext = &extcsd[index]; > + for (i = 0; i < ext->width; i++) { > + val = (value >> (i * 8)) & 0xFF; > + > + mci_switch(mci, index + i, val); > + retval = mci_send_ext_csd(mci, dst); > + if (retval != 0) > + goto error_with_mem; > + } > printf("\nValue written!\n\n"); > - retval = mci_send_ext_csd(mci, dst); > - if (retval != 0) > - goto error_with_mem; > print_field(dst, index); > } > else > Everything else looks good to me. Regards, Bastian -- Pengutronix e.K. Industrial Linux Solutions http://www.pengutronix.de/ Peiner Str. 6-8, 31137 Hildesheim, Germany Amtsgericht Hildesheim, HRA 2686 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox