From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Bastian Krause <bst@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] mfd: rn5t568: add priority to reset_source_set_device()
Date: Mon, 3 Mar 2025 15:44:17 +0100 [thread overview]
Message-ID: <3bb01f7d-f379-49b3-9a1a-250fc9df7ec2@pengutronix.de> (raw)
In-Reply-To: <20250303143144.2953662-1-bst@pengutronix.de>
Hello Bastian,
On 03.03.25 15:31, Bastian Krause wrote:
> 30322f4b565 ("reset_source: give reset_source_set_device a priority
> parameter") introduced a reset source priority parameter, but forgot
> applying a priority the Ricoh RN5T568 PMIC driver's
> reset_source_set_device() call.
>
> So apply the default priority 200 here, too.
>
> Fixes this build error:
>
> drivers/mfd/rn5t568.c: In function 'rn5t568_reset_reason_detect':
> drivers/mfd/rn5t568.c:82:9: error: too few arguments to function 'reset_source_set_device'
> 82 | reset_source_set_device(dev, type);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/mfd/rn5t568.c:17:
> include/reset_source.h:31:6: note: declared here
> 31 | void reset_source_set_device(struct device *dev, enum reset_src_type st,
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 30322f4b565 ("reset_source: give reset_source_set_device a priority parameter")
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
Ouch, sorry for missing the follow-up commit fixing this.
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
We should probably add an allyes build to CI.
Cheers,
Ahmad
> ---
> drivers/mfd/rn5t568.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/rn5t568.c b/drivers/mfd/rn5t568.c
> index 7468338a2d5..e140cea03b0 100644
> --- a/drivers/mfd/rn5t568.c
> +++ b/drivers/mfd/rn5t568.c
> @@ -79,7 +79,7 @@ static int rn5t568_reset_reason_detect(struct device *dev,
> return -EINVAL;
> }
>
> - reset_source_set_device(dev, type);
> + reset_source_set_device(dev, type, 200);
> return 0;
> }
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-03-03 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 14:31 Bastian Krause
2025-03-03 14:44 ` Ahmad Fatoum [this message]
2025-03-04 8:15 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bb01f7d-f379-49b3-9a1a-250fc9df7ec2@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=bst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox