From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH v1] video: edid: print debug message on EDID read out error
Date: Thu, 5 Oct 2023 08:44:26 +0200 [thread overview]
Message-ID: <3e92ee2a-92b5-e21e-30ee-3ffb6eec6fdf@pengutronix.de> (raw)
In-Reply-To: <20230928122133.2587197-1-o.rempel@pengutronix.de>
Hello Oleksij,
On 28.09.23 14:21, Oleksij Rempel wrote:
> From: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
> EDID readout errors happen often, e.g. because the HDMI port doesn't
> have a display connected. However, when a monitor is connected, but some
> other error occurs, barebox is silent. Add a debug message with an error
> code for this.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
This patch had been posted before and Marco had an objection to it:
https://lore.barebox.org/barebox/20221223090605.zis4mcft72crswfm@pengutronix.de/
> ---
> drivers/video/edid.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/edid.c b/drivers/video/edid.c
> index d2757185f6..2baf6646d9 100644
> --- a/drivers/video/edid.c
> +++ b/drivers/video/edid.c
> @@ -852,20 +852,27 @@ edid_do_read_i2c(struct i2c_adapter *adapter, unsigned char *buf,
> ret = i2c_transfer(adapter, &msgs[3 - xfers], xfers);
> } while (ret != xfers && --retries);
>
> - return ret == xfers ? 0 : -1;
> + if (ret == 0)
> + ret = -EPROTO;
> +
> + return ret == xfers ? 0 : ret;
> }
>
> void *edid_read_i2c(struct i2c_adapter *adapter)
> {
> u8 *block;
> + int ret;
>
> if (!IS_ENABLED(CONFIG_I2C))
> return NULL;
>
> block = xmalloc(EDID_LENGTH);
>
> - if (edid_do_read_i2c(adapter, block, 0, EDID_LENGTH))
> + ret = edid_do_read_i2c(adapter, block, 0, EDID_LENGTH);
> + if (ret) {
> + dev_dbg(&adapter->dev, "EDID readout failed: %pe\n", ERR_PTR(ret));
> goto out;
> + }
>
> return block;
> out:
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-10-05 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 12:21 Oleksij Rempel
2023-10-04 7:40 ` Sascha Hauer
2023-10-05 6:44 ` Ahmad Fatoum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e92ee2a-92b5-e21e-30ee-3ffb6eec6fdf@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox