From: "Tomaž Šolc" <tomaz.solc@klevio.com>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 4/5] ARM: rpi: move debug UART Kconfig settings
Date: Thu, 7 Mar 2019 10:52:56 +0100 [thread overview]
Message-ID: <3ea0ed3f-6780-f09d-6e3f-8dd9055dd7f7@klevio.com> (raw)
In-Reply-To: <20190306094239.29413-5-s.hauer@pengutronix.de>
Hi
On 6. 03. 19 10:42, Sascha Hauer wrote:
> In contrast to other architectures, R.Pi debug UART config was placed
> under the "System Type" menu, not under the "Debugging -> low-level
> debugging port". This made this setting easy to miss when enabling low
> level debug mesages.
>
> While at it use the existing base address defines rather than defining
> them again in Kconfig.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm/mach-bcm283x/Kconfig | 20 -------------------
> arch/arm/mach-bcm283x/include/mach/debug_ll.h | 12 +++++++----
> common/Kconfig | 13 ++++++++++++
> 3 files changed, 21 insertions(+), 24 deletions(-)
>
[...]
> diff --git a/arch/arm/mach-bcm283x/include/mach/debug_ll.h b/arch/arm/mach-bcm283x/include/mach/debug_ll.h
> index 2e95bf8320..2d2103e338 100644
> --- a/arch/arm/mach-bcm283x/include/mach/debug_ll.h
> +++ b/arch/arm/mach-bcm283x/include/mach/debug_ll.h
> @@ -20,12 +20,16 @@
>
> #include <mach/platform.h>
>
> -#ifndef CONFIG_MACH_RPI_DEBUG_UART_BASE
> -#define CONFIG_MACH_RPI_DEBUG_UART_BASE 0
> -#endif
> +#ifdef CONFIG_DEBUG_RPI1_UART
> +
> +#define DEBUG_LL_UART_ADDR BCM2835_PL011_BASE
> +#include <debug_ll/pl011.h>
>
> -#define DEBUG_LL_UART_ADDR CONFIG_MACH_RPI_DEBUG_UART_BASE
> +#elif defined CONFIG_DEBUG_RPI2_3_UART
This elif should either be "CONFIG_DEBUG_RPI2_UART" or the Kconfig below
should set DEBUG_RPI2_3_UART.
>
> +#define DEBUG_LL_UART_ADDR BCM2836_PL011_BASE
> #include <debug_ll/pl011.h>
>
> +#endif
> +
> #endif /* __MACH_BCM2835_DEBUG_LL_H__ */
> diff --git a/common/Kconfig b/common/Kconfig
> index 21b33f06f7..563cf15fb1 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -1159,6 +1159,19 @@ config DEBUG_SOCFPGA_UART1
> Say Y here if you want kernel low-level debugging support
> on SOCFPGA(Arria 10) based platforms.
>
> +config DEBUG_RPI1_UART
> + bool "RaspberryPi 1 debug UART"
> + depends on ARCH_BCM283X
> + help
> + Say Y here if you want low-level debugging support on
> + RaspberryPi 1 boards.
> +
> +config DEBUG_RPI2_UART
> + bool "RaspberryPi 2/3 debug UART"
> + depends on ARCH_BCM283X
> + help
> + Say Y here if you want low-level debugging support on
> + RaspberryPi 2 and 3 boards.
>
> endchoice
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-03-07 9:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 9:42 [PATCH 0/5] ARM: rpi: refactor debug_ll Sascha Hauer
2019-03-06 9:42 ` [PATCH 1/5] ARM: rpi: Move UART base address definitions to header file Sascha Hauer
2019-03-06 9:42 ` [PATCH 2/5] debug_ll: Move pl011 header file to architecture independent place Sascha Hauer
2019-03-06 9:42 ` [PATCH 3/5] debug_ll: Add ns16550 early debugging functions Sascha Hauer
2019-03-06 9:42 ` [PATCH 4/5] ARM: rpi: move debug UART Kconfig settings Sascha Hauer
2019-03-07 9:52 ` Tomaž Šolc [this message]
2019-03-06 9:42 ` [PATCH 5/5] ARM: rpi: Add mini UART debug_ll support Sascha Hauer
2019-03-07 9:52 ` Tomaž Šolc
2019-03-07 13:24 ` Sascha Hauer
2019-03-07 13:32 ` [HELP] Kernel + initrd in FIT Seraphim Dolbilov
2019-03-11 7:25 ` Sascha Hauer
2019-03-07 10:00 ` [PATCH 0/5] ARM: rpi: refactor debug_ll Tomaž Šolc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ea0ed3f-6780-f09d-6e3f-8dd9055dd7f7@klevio.com \
--to=tomaz.solc@klevio.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox