From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Thorsten Scherer <T.Scherer@eckelmann.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! commands: add stacksmash command for causing stack overflows
Date: Thu, 14 Sep 2023 13:05:24 +0200 [thread overview]
Message-ID: <440ba82f-5dcc-67e3-5f40-0a35f7a4af97@pengutronix.de> (raw)
In-Reply-To: <20230914102247.ijaw2q7salq6h7ng@nb821.eckelmann.group>
On 14.09.23 12:22, Thorsten Scherer wrote:
> Hi Ahmad,
>
> sha just applied four of the five patches and stacksmash isn't in next
> yet.
>
> Refer,
>
> Message-ID: <20230912093638.GZ637806@pengutronix.de>
He did? 20230912093638.GZ637806@pengutronix.de is an unrelated series:
https://lore.barebox.org/barebox/20230912093638.GZ637806@pengutronix.de/
Cheers,
Ahmad
>
> Best regards,
> Thorsten
>
> On Thu, Sep 14, 2023 at 11:14:38AM +0200, Ahmad Fatoum wrote:
>> commands: stacksmash: fix whitespace in command description
>>
>> Command description mixed spaces and tabs. Fix it to have tabs only.
>>
>> Cc: Thorsten Scherer <T.Scherer@eckelmann.de>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>> Thanks, Thorsten!
>> ---
>> commands/stacksmash.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/commands/stacksmash.c b/commands/stacksmash.c
>> index 1e9be0d40e15..b812d945e215 100644
>> --- a/commands/stacksmash.c
>> +++ b/commands/stacksmash.c
>> @@ -50,9 +50,9 @@ static int do_stacksmash(int argc, char *argv[])
>> panic("Stack smashing of %s not caught\n", argv[1]);
>> }
>> BAREBOX_CMD_START(stacksmash)
>> - .cmd = do_stacksmash,
>> - BAREBOX_CMD_DESC("Run stack smashing tests")
>> + .cmd = do_stacksmash,
>> + BAREBOX_CMD_DESC("Run stack smashing tests")
>> BAREBOX_CMD_OPTS("[frame | region]")
>> - BAREBOX_CMD_GROUP(CMD_GRP_MISC)
>> - BAREBOX_CMD_COMPLETE(empty_complete)
>> + BAREBOX_CMD_GROUP(CMD_GRP_MISC)
>> + BAREBOX_CMD_COMPLETE(empty_complete)
>> BAREBOX_CMD_END
>> --
>> 2.39.2
>>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-09-14 11:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 15:08 [PATCH 0/5] add stack protector and guard page support Ahmad Fatoum
2023-09-11 15:08 ` [PATCH 1/5] include: move PAGE_ definitions into linux/pagemap.h Ahmad Fatoum
2023-09-11 15:08 ` [PATCH 2/5] ARM: mark early C setup functions as __prereloc Ahmad Fatoum
2023-09-11 15:08 ` [PATCH 3/5] lib: add stackprotector support Ahmad Fatoum
2023-09-21 8:52 ` [PATCH] fixup! " Ahmad Fatoum
2023-09-11 15:08 ` [PATCH 4/5] ARM: mmu: catch stack overflowing into TTB with stack guard page Ahmad Fatoum
2023-09-11 15:09 ` [PATCH 5/5] commands: add stacksmash command for causing stack overflows Ahmad Fatoum
2023-09-12 4:48 ` Thorsten Scherer
2023-09-11 15:47 ` [PATCH] fixup! lib: add stackprotector support Ahmad Fatoum
2023-09-14 9:14 ` [PATCH] fixup! commands: add stacksmash command for causing stack overflows Ahmad Fatoum
2023-09-14 10:22 ` Thorsten Scherer
2023-09-14 11:05 ` Ahmad Fatoum [this message]
2023-09-21 8:49 ` [PATCH 0/5] add stack protector and guard page support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440ba82f-5dcc-67e3-5f40-0a35f7a4af97@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=T.Scherer@eckelmann.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox