mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Stefan Riedmüller" <s.riedmueller@phytec.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	barebox@lists.infradead.org
Subject: Re: [PATCH RFC] imx6ul-phytec-phycore-som: don't use fsl,no-blockmark-swap for the NAND
Date: Thu, 10 Jan 2019 16:56:10 +0100	[thread overview]
Message-ID: <44c7edc5-ad92-eaa2-a3b9-20d7748331ec@phytec.de> (raw)
In-Reply-To: <20190108102412.10553-1-u.kleine-koenig@pengutronix.de>

Hi Uwe,

On 08.01.19 11:24, Uwe Kleine-König wrote:
> barebox doesn't honor that property which yields to inconsitencies
> between Linux and barebox after for example filling an UBI with a file
> system with barebox and then trying to mount that from Linux.
> 
> Note this is an interruptive change as it requires to rewrite the flash
> to make it working with Linux again.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> I wonder why Phytec chose to use this configuration. Was this just
> copied from another board?

I have to admit, I don't know why this configuration was added. I guess it was 
added unintentionally since we do not use this configuration in the kernel.

So from my side there is no objection to this patch.

Thanks for spoting this and best regards
Stefan

> 
> Best regards
> Uwe
> 
>   arch/arm/dts/imx6ul-phytec-phycore-som.dtsi | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/dts/imx6ul-phytec-phycore-som.dtsi b/arch/arm/dts/imx6ul-phytec-phycore-som.dtsi
> index d829fdd6fb29..398546d7b92e 100644
> --- a/arch/arm/dts/imx6ul-phytec-phycore-som.dtsi
> +++ b/arch/arm/dts/imx6ul-phytec-phycore-som.dtsi
> @@ -49,7 +49,6 @@
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&pinctrl_gpmi_nand>;
>   	nand-on-flash-bbt;
> -	fsl,no-blockmark-swap;
>   	status = "disabled";
>   
>   	#address-cells = <1>;
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-01-10 15:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08 10:24 [PATCH RFC] imx6ul-phytec-phycore-som: don't use fsl, no-blockmark-swap " Uwe Kleine-König
2019-01-10 15:56 ` Stefan Riedmüller [this message]
2019-01-11 11:03 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44c7edc5-ad92-eaa2-a3b9-20d7748331ec@phytec.de \
    --to=s.riedmueller@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox