From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 29 Aug 2023 12:46:18 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qawEl-00DD1c-Sh for lore@lore.pengutronix.de; Tue, 29 Aug 2023 12:46:18 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qawEj-0005Uk-Lp for lore@pengutronix.de; Tue, 29 Aug 2023 12:46:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x2ta/xlf4WwOEnF2ZsWg20oIUtgOzqvIhXeazNy8e9M=; b=VwvcJ9OOXGi6mSPNJi0S1upInc PwIutVJeKfzq07ShB7y/8tDBltbZf4VoLvnC3zwJiTA/+0d7bbxJewkSzyUZKo2C4cf5lrV8pWB29 /+rqDjKuct2DzrcW/QHiEvUxBghEhu75yvT/GRlzyjzrF0psi7JLDyHm9TkbL3vzKXprfpQCkQpkN Ch2+BCa/9qJGAhJg3dpMKj48Bu8udcV9lop7C5VW56M687KBpEZBWI6U4eXTFYr040y00YFVKFFjW xX4gjV0CAZ3g1s1XreBqGm6c+pyAOb2lsSBH1hccprLIXMBztKdYXr4P9E3Zt8kkdWW8u8U9MmZk6 SoaL1Vkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qawDZ-00BK1a-3B; Tue, 29 Aug 2023 10:45:05 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qawDW-00BK0f-2X for barebox@lists.infradead.org; Tue, 29 Aug 2023 10:45:04 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qawDU-0005Bs-Hu; Tue, 29 Aug 2023 12:45:00 +0200 Message-ID: <44ee704c-8e28-a0a6-6627-c33f0bd56d3d@pengutronix.de> Date: Tue, 29 Aug 2023 12:45:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US From: Ahmad Fatoum To: Johannes Zink , patchwork-jzi@pengutronix.de Cc: Barebox Mailing List References: <20230829-crc32_in_pbl-v1-1-6a3e01a74c8d@pengutronix.de> <7101f4d9-9ebc-9d73-40a5-85a96c34589c@pengutronix.de> In-Reply-To: <7101f4d9-9ebc-9d73-40a5-85a96c34589c@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_034502_821532_5148CF3B X-CRM114-Status: GOOD ( 23.17 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.5 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] crypto: crc32: make crc32 available in PBL X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 29.08.23 12:29, Ahmad Fatoum wrote: > On 29.08.23 11:28, Johannes Zink wrote: >> crc32 may be required in PBL for checking data integrity. Add >> CONFIG_CRC32_EARLY to kconfig which allows adding crc32 also in the PBL. >> >> As the PBL has no dynamic allocation, do not use dynamic CRC table >> generation when CRC32 is added in PBL. >> >> Signed-off-by: Johannes Zink >> --- >> To: Barebox Mailing List >> Cc: Johannes Zink >> Cc: patchwork-jzi@pengutronix.de >> --- >> crypto/Kconfig | 3 +++ >> crypto/Makefile | 1 + >> crypto/crc32.c | 6 +++--- >> 3 files changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/crypto/Kconfig b/crypto/Kconfig >> index 04e5ef43705b..6e18b5868061 100644 >> --- a/crypto/Kconfig >> +++ b/crypto/Kconfig >> @@ -5,6 +5,9 @@ menu "Crypto support" >> config CRC32 >> bool >> >> +config CRC32_EARLY >> + bool >> + >> config CRC_ITU_T >> bool >> >> diff --git a/crypto/Makefile b/crypto/Makefile >> index 22035d4f69ee..24e1f3d91797 100644 >> --- a/crypto/Makefile >> +++ b/crypto/Makefile >> @@ -11,6 +11,7 @@ obj-$(CONFIG_DIGEST_SHA1_GENERIC) += sha1.o >> obj-$(CONFIG_DIGEST_SHA224_GENERIC) += sha2.o >> obj-$(CONFIG_DIGEST_SHA256_GENERIC) += sha2.o >> pbl-y += sha2.o digest.o >> +lwl-$(CONFIG_CRC32_EARLY) += crc32.o > > pbl-obj- is the correct prefix. lwl- means pbl- if we have PBL > support at all and obj- otherwise (for legacy systems without PBL), > while pbl-obj- is equivalent to duplicating the line once with pbl- > and once with obj- s/pbl-obj-/obj-pbl-/ :) > >> obj-$(CONFIG_DIGEST_SHA384_GENERIC) += sha4.o >> obj-$(CONFIG_DIGEST_SHA512_GENERIC) += sha4.o >> obj-y += memneq.o >> diff --git a/crypto/crc32.c b/crypto/crc32.c >> index 95cb2212db2b..284d39351682 100644 >> --- a/crypto/crc32.c >> +++ b/crypto/crc32.c >> @@ -22,7 +22,7 @@ >> #define STATIC static inline >> #endif >> >> -#ifdef CONFIG_DYNAMIC_CRC_TABLE >> +#if defined(CONFIG_DYNAMIC_CRC_TABLE) && !defined(__PBL__) > > You could also replace the dynamic allocation with a static array initialized > to zero. That way you can have a dynamic crc table even in PBL without affecting > image size as the BSS is not part of the image. > >> >> static uint32_t *crc_table; >> >> @@ -145,7 +145,7 @@ STATIC uint32_t crc32(uint32_t crc, const void *_buf, unsigned int len) >> { >> const unsigned char *buf = _buf; >> >> -#ifdef CONFIG_DYNAMIC_CRC_TABLE >> +#if defined(CONFIG_DYNAMIC_CRC_TABLE) && !defined(__PBL__) >> if (!crc_table) >> make_crc_table(); >> #endif >> @@ -171,7 +171,7 @@ STATIC uint32_t crc32_no_comp(uint32_t crc, const void *_buf, unsigned int len) >> { >> const unsigned char *buf = _buf; >> >> -#ifdef CONFIG_DYNAMIC_CRC_TABLE >> +#if defined(CONFIG_DYNAMIC_CRC_TABLE) && !defined(__PBL__) >> if (!crc_table) >> make_crc_table(); >> #endif >> >> --- >> base-commit: bef38b18eeb5d2f1fac334fb8b831e47261e099c >> change-id: 20230829-crc32_in_pbl-4d824629d4e2 >> >> Best regards, > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |