From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 02 Jan 2024 18:04:33 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rKiBt-000qRw-1e for lore@lore.pengutronix.de; Tue, 02 Jan 2024 18:04:33 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rKiBs-00081C-EM for lore@pengutronix.de; Tue, 02 Jan 2024 18:04:32 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MzNJsDNFleRf0COfDkjBPGeLPw5PUE5onzmdGtVAlDw=; b=ZkWiMl9DtKgBygXQfgrELLzmyA nCoqcLr7/b8ZhSw5qFDn6OvIhjafwZsMAtKZZPFsLF3NurgryUJyJt3B60wX0V7xXVHquzhEl+DMp tenBxinZXS23wWMmvgxilRJ44+zSwAeysEI8WM+PQMmE1X/hsn1eJtyOhMwk4dm2Et4N+OF4mAPHm GKlrqMUPiodHmvwlryOyB1XwvTYtG6wqnDcdyBLm4n/2DP3+SgNiyqv/1RGtjY1/bYERisEeJ/gfW gXLm3IlULxgsGJdEYJROXg4qj/7wlZauG4hsmflgTYerY+LKVm9haC4/s2KEYj18vKo/RxWLQZgSA AW1gM1UQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rKiAz-008Ydn-1d; Tue, 02 Jan 2024 17:03:37 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rKiAw-008Ycm-1V for barebox@lists.infradead.org; Tue, 02 Jan 2024 17:03:36 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rKiAv-0007me-8n; Tue, 02 Jan 2024 18:03:33 +0100 Message-ID: <46848701-b505-4c72-bc0d-58bcf4c0d5c3@pengutronix.de> Date: Tue, 2 Jan 2024 18:03:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Ahmad Fatoum To: robin@protonic.nl Cc: barebox@lists.infradead.org, michiel.schelfhout@protonic.nl References: <20231220082908.360302-1-robin@protonic.nl> <27a9d947-2358-4e05-ba77-32b26b3b3125@pengutronix.de> <97b2f99e62f57627604f11cce4c95b6b@protonic.nl> <163649a2-19b2-4e44-a8e3-4a816afdbef1@pengutronix.de> In-Reply-To: <163649a2-19b2-4e44-a8e3-4a816afdbef1@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240102_090334_499595_B0F0E7FD X-CRM114-Status: GOOD ( 17.17 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-6.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2] nvmem: regmap: Fix nvmem size X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hello Robin, On 21.12.23 15:02, Ahmad Fatoum wrote: > On 20.12.23 13:38, Robin van der Gracht wrote: >> Hi Ahmad, >> >> On 2023-12-20 10:00, Ahmad Fatoum wrote: >>> Hello Robin, >>> >>> Thanks for the fix. >>> >>> On 20.12.23 09:29, Robin van der Gracht wrote: >>>> -    if (roffset + rbytes > stride * regmap_get_max_register(map)) >>>> +    if (roffset + rbytes > regmap_size_bytes(map) * stride) >>> >>> Shouldn't stride on the right hand side be dropped? >> >> roffset = register index * stride. >> >> I.e. 380 for register with index 95. >> >> For stm32mp1x bsec: >>  map->format.val_bytes = 4 >>  map->reg_stride = 4 >> >> regmap_size_bytes() = map->format.val_bytes * (95 + 1) / map->reg_stride = 96 > > Ouch. What have I been thinking when I named regmap_size_bytes() this way... > Change looks ok then, but we should really rename regmap_size_bytes()... After talking it over with Sascha, I see that the name is correct with regard to how the function was initially used. What's wrong it the implementation and that goes back to 2016.. I just sent out a series fixing this. md -s /dev/stm32-bsec 380 now works. Please verify if it's behaving as you expect. Thanks, Ahmad > >> >> So the result with the stride on the right size is correct. >> >> I moved stride from left to right to be consistent with the size calculation >> in nvmem_regmap_register_with_pp() >> >> Kind regards, >> Robin >> >> >>> >>> Cheers, >>> Ahmad >>> >>>>          return -EINVAL; >>>> >>>>      for (i = roffset; i < roffset + rbytes; i += stride) { >>>> @@ -78,7 +78,7 @@ nvmem_regmap_register_with_pp(struct regmap *map, const char *name, >>>>      config.priv = map; >>>>      config.stride = 1; >>>>      config.word_size = 1; >>>> -    config.size = regmap_get_max_register(map) * regmap_get_reg_stride(map); >>>> +    config.size = regmap_size_bytes(map) * regmap_get_reg_stride(map); >>>>      config.cell_post_process = cell_post_process; >>>>      config.reg_write = nvmem_regmap_write; >>>>      config.reg_read = nvmem_regmap_read; >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |