Re: [PATCH v2 5/5] pmdomain: add Rockchip power domain support

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 10/28/25 10:48 AM, Sascha Hauer wrote:
> On Tue, Oct 28, 2025 at 10:04:06AM +0100, Ahmad Fatoum wrote:
>>
>>
>> On 10/28/25 9:57 AM, Sascha Hauer wrote:
>>> On Mon, Oct 27, 2025 at 08:28:20PM +0100, Ahmad Fatoum wrote:
>>>> +static int rockchip_pm_add_subdomain(struct rockchip_pmu *pmu,
>>>> +				     struct device_node *parent)
>>>> +{
>>>> +	struct device_node *np;
>>>> +
>>>> +	for_each_child_of_node(parent, np)
>>>> +		return -ENOSYS;
>>>> +
>>>
>>> I gave it a quick try on RK3588 and driver probe fails here. RK3588 has
>>> several subdomains in its power controller.
>>
>> I need it on rk3566 though, otherwise the probe hangs. Should I drop the
>> rk358x compatibles?
> 
> That leaves us with the warnings introduced with the last patch:
> 
> WARNING: dwc3 fc000000.usb@fc000000.of: power domain not found (ignoring)
> WARNING: rockchip-dw-pcie a40c00000.pcie@fe180000.of: power domain not found (ignoring)
> WARNING: rockchip-dw-pcie a41000000.pcie@fe190000.of: power domain not found (ignoring)
> WARNING: dw_mmc fe2c0000.mmc@fe2c0000.of: power domain not found (ignoring)
> WARNING: dwc3 fc400000.usb@fc400000.of: power domain not found (ignoring)
> WARNING: rockchip-dw-pcie a40400000.pcie@fe160000.of: power domain not found (ignoring)

Is PCIe working right now?

> Maybe add a dummy driver where people can add their compatible to when
> they encounter the warning knowing that their SoC doesn't need a power
> domain driver?

Are you sure the power domains are indeed unneeded?

Alexander and Michael have been doing RK3588 work recently, any thoughts
from your side?

Cheers,
Ahmad

> 
> Sascha
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |