From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: PROPOSED patch, standardize drivers menuconfig entries
Date: Tue, 22 Dec 2009 17:54:50 +0100 [thread overview]
Message-ID: <4B30F9DA.2030907@pengutronix.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0912221113050.6101@localhost>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Robert P. J. Day wrote:
> here's a newer pass at cleaning up the drivers menuconfig structure,
> not being officially submitted, i'm going to make another pass and see
> if i missed anything, but i'm open to suggestions. some observations:
>
> - *all* drivers are now selectable at the top level
> - because of that, there's no need to re-test that same
> macro in the subdir, which is why some of those lower
> Makefiles now have obj-y.
>
> if this looks good, then i'll submit it for real.
There are some selects that should be fixed, my mx35 shows this error:
arch/arm/mach-imx/Kconfig:173:warning: 'select' used by config symbol 'MACH_PCM038' refers to undefined symbol 'SPI'
arch/arm/mach-imx/Kconfig:217:warning: 'select' used by config symbol 'MACH_FREESCALE_MX35_3STACK' refers to undefined symbol 'I2C'
There's a "#ifdef CONFIG_I2C" in i2c.h, maybe there are more ifdefs.
IMHO there should be reasonable defaults for the new menus...
cheers, Marc
- --
Pengutronix e.K. | Marc Kleine-Budde |
Linux Solutions for Science and Industry | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAksw+doACgkQjTAFq1RaXHO1yQCgj0wACcd6+pVdQf41vOHq74Dn
7KMAnjSDh6YzNKd4PG47IpnR4ghcH4pz
=A+rt
-----END PGP SIGNATURE-----
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2009-12-22 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 16:16 Robert P. J. Day
2009-12-22 16:54 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B30F9DA.2030907@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox