mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: barebox@lists.infradead.org
Cc: sha@pengutronix.de
Subject: Re: [PATCH 05/11] drivers/video/Makefile: cleanup propper indention
Date: Tue, 16 Feb 2010 21:35:40 +0100	[thread overview]
Message-ID: <4B7B019C.60601@pengutronix.de> (raw)
In-Reply-To: <1266331586-11253-6-git-send-email-mkl@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 1143 bytes --]

Marc Kleine-Budde wrote:
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  drivers/video/Makefile |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
> index 1e0d1b9..45ee09e 100644
> --- a/drivers/video/Makefile
> +++ b/drivers/video/Makefile
> @@ -1,3 +1,4 @@
> -obj-$(CONFIG_VIDEO)	+= fb.o
> -obj-$(CONFIG_DRIVER_VIDEO_IMX)	+= imx.o
> -obj-$(CONFIG_DRIVER_VIDEO_IMX_IPU) += imx-ipu-fb.o
> +obj-$(CONFIG_VIDEO)			+= fb.o
> +
> +obj-$(CONFIG_DRIVER_VIDEO_IMX)		+= imx.o
> +obj-$(CONFIG_DRIVER_VIDEO_IMX_IPU)	+= imx-ipu-fb.o

As Uwe pointed out indention with tabs isn't good in the long term. As
soon as a longer config option occurs the whole indention is broken again.

I'll convert the two files into a "just one space" style.

cheers, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2010-02-16 20:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16 14:46 [PATCH 00/11] arch/arm and other random cleanups Marc Kleine-Budde
2010-02-16 14:46 ` [PATCH 01/11] arm/Kconfig: delete trailing whitespace Marc Kleine-Budde
2010-02-16 14:46   ` [PATCH 02/11] arm/Kconfig: removed unused TAG options Marc Kleine-Budde
2010-02-16 14:46     ` [PATCH 03/11] arm/Makefile: keep list of boards sorted Marc Kleine-Budde
2010-02-16 14:46       ` [PATCH 04/11] arm/cpu/Makefile: cleanup: propper indention Marc Kleine-Budde
2010-02-16 14:46         ` [PATCH 05/11] drivers/video/Makefile: cleanup " Marc Kleine-Budde
2010-02-16 14:46           ` [PATCH 06/11] start-arm: cleanup: " Marc Kleine-Budde
2010-02-16 14:46             ` [PATCH 07/11] i2c.h: fix typo in copyright Marc Kleine-Budde
2010-02-16 14:46               ` [PATCH 08/11] ioreadsb: put the whole ioreadsb function into the .text.readsb section Marc Kleine-Budde
2010-02-16 14:46                 ` [PATCH 09/11] import recent include/linux/compiler*.h Marc Kleine-Budde
2010-02-16 14:46                   ` [PATCH 10/11] io.h: update definitions of __raw_{read,write}* Marc Kleine-Budde
2010-02-16 14:46                     ` [PATCH 11/11] common.h: add compile time check helper functions Marc Kleine-Budde
2010-02-16 15:01             ` [PATCH 06/11] start-arm: cleanup: propper indention Uwe Kleine-König
2010-02-16 20:35           ` Marc Kleine-Budde [this message]
2010-02-16 14:54 ` [PATCH 00/11] arch/arm and other random cleanups Marc Kleine-Budde
2010-02-17  9:46   ` Sascha Hauer
2010-02-17 22:20     ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7B019C.60601@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sha@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox