Hello Marc,

Marc Reilly wrote:
> This pad is an interrupt source, active low for one of the external ICs.

just nitpicking from my side, see comments inline.

Cheers, Marc

> ---
>  board/freescale-mx35-3-stack/3stack.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/board/freescale-mx35-3-stack/3stack.c b/board/freescale-mx35-3-stack/3stack.c
> index 4dc25e6..797e517 100644
> --- a/board/freescale-mx35-3-stack/3stack.c
> +++ b/board/freescale-mx35-3-stack/3stack.c
> @@ -280,6 +280,8 @@ static struct pad_desc f3s_pads[] = {
>  	MX35_PAD_I2C1_DAT__I2C1_SDA,
>  
>  	MX35_PAD_WDOG_RST__GPIO1_6,
> +	MX35_PAD_COMPARE__GPIO1_5,
> +	

no trailing whitespace, please

>  	/* Display */
>  	MX35_PAD_LD0__IPU_DISPB_DAT_0,
>  	MX35_PAD_LD1__IPU_DISPB_DAT_1,
> @@ -332,7 +334,7 @@ static int f3s_core_init(void)
>  	reg |= 0x3 << CCM_CGR1_FEC_SHIFT;
>  	reg |= 0x3 << CCM_CGR1_I2C1_SHIFT;
>  	reg = writel(reg, IMX_CCM_BASE + CCM_CGR1);
> -
> +	

dito

>  	/* AIPS setup - Only setup MPROTx registers. The PACR default values are good.*/
>  	/*
>  	 * Set all MPROTx to be non-bufferable, trusted for R/W,
> @@ -414,6 +416,9 @@ static int f3s_pmic_init_v2(struct mc13892 *mc13892)
>  {
>  	int err = 0;
>  
> +	/* COMPARE pin (GPIO1_5) as output and set high */
> +	gpio_direction_output( 32*0 + 5 , 1);
> +	

dito

>  	err |= mc13892_set_bits(mc13892, MC13892_REG_SETTING_0, 0x03, 0x03);
>  	err |= mc13892_set_bits(mc13892, MC13892_REG_MODE_0, 0x01, 0x01);
>  	if (err)


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |