From: Marc Kleine-Budde <mkl@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH] drivers: mci: Fix compilation warning.
Date: Thu, 25 Nov 2010 13:48:54 +0100 [thread overview]
Message-ID: <4CEE5B36.90309@pengutronix.de> (raw)
In-Reply-To: <1290688903-24955-1-git-send-email-marek.belisko@open-nandra.com>
[-- Attachment #1.1: Type: text/plain, Size: 1206 bytes --]
On 11/25/2010 01:41 PM, Marek Belisko wrote:
> Fix compilation warning:
> drivers/mci/mci-core.c:1002:
> warning: comparison of distinct pointer types lacks a cast
>
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
> drivers/mci/mci-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index a8aa486..bc82201 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -999,7 +999,7 @@ static int mci_sd_read(struct device_d *disk_dev, uint64_t sector_start,
> }
>
> while (sector_count) {
> - int now = min(sector_count, 32);
> + int now = min(sector_count, (unsigned) 32);
for raw numbers you usually add a prefix "U".
> if (sector_start > MAX_BUFFER_NUMBER) {
> pr_err("Cannot handle block number %lu. Too large!\n",
> (unsigned)sector_start);
cheers, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-11-25 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 12:41 Marek Belisko
2010-11-25 12:48 ` Marc Kleine-Budde [this message]
2010-11-25 13:23 ` Belisko Marek
2010-11-25 14:21 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEE5B36.90309@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox