* [PATCH] drivers: mci: Fix compilation warning.
@ 2010-11-25 12:41 Marek Belisko
2010-11-25 12:48 ` Marc Kleine-Budde
0 siblings, 1 reply; 4+ messages in thread
From: Marek Belisko @ 2010-11-25 12:41 UTC (permalink / raw)
To: barebox; +Cc: Marek Belisko
Fix compilation warning:
drivers/mci/mci-core.c:1002:
warning: comparison of distinct pointer types lacks a cast
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
drivers/mci/mci-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index a8aa486..bc82201 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -999,7 +999,7 @@ static int mci_sd_read(struct device_d *disk_dev, uint64_t sector_start,
}
while (sector_count) {
- int now = min(sector_count, 32);
+ int now = min(sector_count, (unsigned) 32);
if (sector_start > MAX_BUFFER_NUMBER) {
pr_err("Cannot handle block number %lu. Too large!\n",
(unsigned)sector_start);
--
1.7.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: mci: Fix compilation warning.
2010-11-25 12:41 [PATCH] drivers: mci: Fix compilation warning Marek Belisko
@ 2010-11-25 12:48 ` Marc Kleine-Budde
2010-11-25 13:23 ` Belisko Marek
0 siblings, 1 reply; 4+ messages in thread
From: Marc Kleine-Budde @ 2010-11-25 12:48 UTC (permalink / raw)
To: barebox
[-- Attachment #1.1: Type: text/plain, Size: 1206 bytes --]
On 11/25/2010 01:41 PM, Marek Belisko wrote:
> Fix compilation warning:
> drivers/mci/mci-core.c:1002:
> warning: comparison of distinct pointer types lacks a cast
>
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
> drivers/mci/mci-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
> index a8aa486..bc82201 100644
> --- a/drivers/mci/mci-core.c
> +++ b/drivers/mci/mci-core.c
> @@ -999,7 +999,7 @@ static int mci_sd_read(struct device_d *disk_dev, uint64_t sector_start,
> }
>
> while (sector_count) {
> - int now = min(sector_count, 32);
> + int now = min(sector_count, (unsigned) 32);
for raw numbers you usually add a prefix "U".
> if (sector_start > MAX_BUFFER_NUMBER) {
> pr_err("Cannot handle block number %lu. Too large!\n",
> (unsigned)sector_start);
cheers, Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: mci: Fix compilation warning.
2010-11-25 12:48 ` Marc Kleine-Budde
@ 2010-11-25 13:23 ` Belisko Marek
2010-11-25 14:21 ` Marc Kleine-Budde
0 siblings, 1 reply; 4+ messages in thread
From: Belisko Marek @ 2010-11-25 13:23 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: barebox
On Thu, Nov 25, 2010 at 1:48 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> On 11/25/2010 01:41 PM, Marek Belisko wrote:
>> Fix compilation warning:
>> drivers/mci/mci-core.c:1002:
>> warning: comparison of distinct pointer types lacks a cast
>>
>> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> ---
>> drivers/mci/mci-core.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
>> index a8aa486..bc82201 100644
>> --- a/drivers/mci/mci-core.c
>> +++ b/drivers/mci/mci-core.c
>> @@ -999,7 +999,7 @@ static int mci_sd_read(struct device_d *disk_dev, uint64_t sector_start,
>> }
>>
>> while (sector_count) {
>> - int now = min(sector_count, 32);
>> + int now = min(sector_count, (unsigned) 32);
>
> for raw numbers you usually add a prefix "U".
Hopefully you mean suffix :) 32U. Will resend.
>
>> if (sector_start > MAX_BUFFER_NUMBER) {
>> pr_err("Cannot handle block number %lu. Too large!\n",
>> (unsigned)sector_start);
>
> cheers, Marc
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Industrial Linux Solutions | Phone: +49-231-2826-924 |
> Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
>
thanks,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: mci: Fix compilation warning.
2010-11-25 13:23 ` Belisko Marek
@ 2010-11-25 14:21 ` Marc Kleine-Budde
0 siblings, 0 replies; 4+ messages in thread
From: Marc Kleine-Budde @ 2010-11-25 14:21 UTC (permalink / raw)
To: Belisko Marek; +Cc: barebox
[-- Attachment #1.1: Type: text/plain, Size: 1315 bytes --]
On 11/25/2010 02:23 PM, Belisko Marek wrote:
> On Thu, Nov 25, 2010 at 1:48 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>> On 11/25/2010 01:41 PM, Marek Belisko wrote:
>>> Fix compilation warning:
>>> drivers/mci/mci-core.c:1002:
>>> warning: comparison of distinct pointer types lacks a cast
>>>
>>> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>>> ---
>>> drivers/mci/mci-core.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
>>> index a8aa486..bc82201 100644
>>> --- a/drivers/mci/mci-core.c
>>> +++ b/drivers/mci/mci-core.c
>>> @@ -999,7 +999,7 @@ static int mci_sd_read(struct device_d *disk_dev, uint64_t sector_start,
>>> }
>>>
>>> while (sector_count) {
>>> - int now = min(sector_count, 32);
>>> + int now = min(sector_count, (unsigned) 32);
>>
>> for raw numbers you usually add a prefix "U".
> Hopefully you mean suffix :) 32U. Will resend.
DOH!
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-25 14:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-25 12:41 [PATCH] drivers: mci: Fix compilation warning Marek Belisko
2010-11-25 12:48 ` Marc Kleine-Budde
2010-11-25 13:23 ` Belisko Marek
2010-11-25 14:21 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox