mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/1] BMP: Add support for 32bpp video frame buffer
@ 2011-01-04 14:39 Gregory CLEMENT
  2011-01-13 15:14 ` Gregory CLEMENT
  0 siblings, 1 reply; 3+ messages in thread
From: Gregory CLEMENT @ 2011-01-04 14:39 UTC (permalink / raw)
  To: barebox

Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
 commands/bmp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/commands/bmp.c b/commands/bmp.c
index 5bac031..644a977 100644
--- a/commands/bmp.c
+++ b/commands/bmp.c
@@ -25,6 +25,7 @@ static inline void set_pixel(struct fb_info *info, void *adr, int r, int g, int
 		*(u16 *)adr = px;
 		break;
 	case 32:
+		*(u32 *)adr = px;
 		break;
 	}
 }
-- 
1.7.0.4



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] BMP: Add support for 32bpp video frame buffer
  2011-01-04 14:39 [PATCH 1/1] BMP: Add support for 32bpp video frame buffer Gregory CLEMENT
@ 2011-01-13 15:14 ` Gregory CLEMENT
  2011-01-14  9:45   ` Sascha Hauer
  0 siblings, 1 reply; 3+ messages in thread
From: Gregory CLEMENT @ 2011-01-13 15:14 UTC (permalink / raw)
  To: barebox

On 01/04/2011 03:39 PM, Gregory CLEMENT wrote:
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  commands/bmp.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/commands/bmp.c b/commands/bmp.c
> index 5bac031..644a977 100644
> --- a/commands/bmp.c
> +++ b/commands/bmp.c
> @@ -25,6 +25,7 @@ static inline void set_pixel(struct fb_info *info, void *adr, int r, int g, int
>  		*(u16 *)adr = px;
>  		break;
>  	case 32:
> +		*(u32 *)adr = px;
>  		break;
>  	}
>  }
Any comments for this patch?

It seems pretty trivial and it works at least for me.
But if I missed something, let me know.

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] BMP: Add support for 32bpp video frame buffer
  2011-01-13 15:14 ` Gregory CLEMENT
@ 2011-01-14  9:45   ` Sascha Hauer
  0 siblings, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2011-01-14  9:45 UTC (permalink / raw)
  To: Gregory CLEMENT; +Cc: barebox

On Thu, Jan 13, 2011 at 04:14:45PM +0100, Gregory CLEMENT wrote:
> On 01/04/2011 03:39 PM, Gregory CLEMENT wrote:
> > Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> > ---
> >  commands/bmp.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/commands/bmp.c b/commands/bmp.c
> > index 5bac031..644a977 100644
> > --- a/commands/bmp.c
> > +++ b/commands/bmp.c
> > @@ -25,6 +25,7 @@ static inline void set_pixel(struct fb_info *info, void *adr, int r, int g, int
> >  		*(u16 *)adr = px;
> >  		break;
> >  	case 32:
> > +		*(u32 *)adr = px;
> >  		break;
> >  	}
> >  }
> Any comments for this patch?
> 
> It seems pretty trivial and it works at least for me.
> But if I missed something, let me know.

Sorry, missed it. Applied now.

Thanks
 Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-01-14  9:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-04 14:39 [PATCH 1/1] BMP: Add support for 32bpp video frame buffer Gregory CLEMENT
2011-01-13 15:14 ` Gregory CLEMENT
2011-01-14  9:45   ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox