From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fb: update cdev map_base
Date: Mon, 17 Jan 2011 10:38:38 +0100 [thread overview]
Message-ID: <4D340E1E.3020608@free-electrons.com> (raw)
In-Reply-To: <1295034524-18722-2-git-send-email-s.hauer@pengutronix.de>
Hi Sascha,
You can revert the patch 1/4 I sent and add my Tested-by on this one.
On 01/14/2011 08:48 PM, Sascha Hauer wrote:
> Calling fb_activate_var potentially changes the framebuffer address,
> so we have to update the fb0 cdev afterwards.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/video/fb.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/fb.c b/drivers/video/fb.c
> index aad0e1f..ba34b9c 100644
> --- a/drivers/video/fb.c
> +++ b/drivers/video/fb.c
> @@ -79,6 +79,8 @@ static int fb_setup_mode(struct device_d *dev, struct param_d *param,
>
> ret = info->fbops->fb_activate_var(info);
>
> + dev->map_base = (unsigned long)info->screen_base;
> +
> if (ret == 0)
> dev_param_set_generic(dev, param, val);
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-01-17 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 19:48 fix framebuffer memory base address Sascha Hauer
2011-01-14 19:48 ` [PATCH] fb: update cdev map_base Sascha Hauer
2011-01-17 9:38 ` Gregory CLEMENT [this message]
2011-01-17 17:58 ` Sascha Hauer
2011-01-15 16:54 ` fix framebuffer memory base address Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D340E1E.3020608@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox