mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 05/10] i.MX23/28: Fix setting of lcd clock
Date: Thu, 20 Jan 2011 15:01:47 +0100	[thread overview]
Message-ID: <4D38404B.1020204@free-electrons.com> (raw)
In-Reply-To: <1295516821-8988-6-git-send-email-s.hauer@pengutronix.de>

On 01/20/2011 10:46 AM, Sascha Hauer wrote:
> Use the correct bitmask for masking out which is
> SET_PIXFRAC(MASK_PIXFRAC)
> 

I was just about to send you the same kind of patch, as this bug bit me during
kernel boot when using cpufreq.

As you are working on imx23 and video driver, what do you think of my previous
patches ? I sent them in January the 4th:

ARM STM/i.MX: Add possibility to choose the bit per pixel for STM
    video driver
ARM STM/i.MX: Add possibility to select the data mode for stm video
      driver ( DCn signal is high )
ARM STM/i.MX: Add the reset control of LCD

They should need to be rebased on this new patch set as you made some changes
with the name of the structures and the name of the files. But before doing
this I would like to know if there was a chance that they will be applied in
barebox.


> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  arch/arm/mach-stm/imx_lcd_clk.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-stm/imx_lcd_clk.c b/arch/arm/mach-stm/imx_lcd_clk.c
> index 8938664..65bfc6e 100644
> --- a/arch/arm/mach-stm/imx_lcd_clk.c
> +++ b/arch/arm/mach-stm/imx_lcd_clk.c
> @@ -120,7 +120,8 @@ unsigned imx_set_lcdifclk(unsigned nc)
>  			best_frac, best_div, 480 * 18 / best_frac,
>  			480000 * 18 / best_frac / best_div);
>  
> -	reg = readl(IMX_CCM_BASE + HW_CLKCTRL_FRAC) & ~MASK_PIXFRAC;
> +	reg = readl(IMX_CCM_BASE + HW_CLKCTRL_FRAC);
> +	reg &= ~SET_PIXFRAC(MASK_PIXFRAC);
>  	reg |= SET_PIXFRAC(best_frac);
>  	writel(reg, IMX_CCM_BASE + HW_CLKCTRL_FRAC);
>  	writel(reg & ~CLKCTRL_FRAC_CLKGATEPIX, IMX_CCM_BASE + HW_CLKCTRL_FRAC);


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
+33 602 196 044

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-01-20 14:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20  9:46 i.MX23 patches Sascha Hauer
2011-01-20  9:46 ` [PATCH 01/10] USB ehci: Set to host mode on tt capable controllers Sascha Hauer
2011-01-20  9:46 ` [PATCH 02/10] i.MX23: Add USB (phy) support Sascha Hauer
2011-01-20  9:46 ` [PATCH 03/10] ARM Chumby: Add USB support Sascha Hauer
2011-01-20  9:46 ` [PATCH 04/10] ARM Chumby: Add MMU support Sascha Hauer
2011-01-20  9:46 ` [PATCH 05/10] i.MX23/28: Fix setting of lcd clock Sascha Hauer
2011-01-20 14:01   ` Gregory CLEMENT [this message]
2011-01-20 14:57     ` Sascha Hauer
2011-01-20 17:52       ` Gregory CLEMENT
2011-01-21  9:37         ` Sascha Hauer
2011-01-20  9:46 ` [PATCH 06/10] fb i.MX23/28: add platform data hook to enable backlight Sascha Hauer
2011-01-20  9:46 ` [PATCH 07/10] ARM chumby: enable backlight in platform data hook Sascha Hauer
2011-01-20  9:46 ` [PATCH 08/10] fb i.MX23/28: rename imx_fb_videomode to imx_fb_platformdata Sascha Hauer
2011-01-20  9:47 ` [PATCH 09/10] ARM: rename STM arch to mxs Sascha Hauer
2011-01-20  9:47 ` [PATCH 10/10] ARM chumby defconfig: update with new features Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D38404B.1020204@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox