From: Thomas Mayer <thomas.mayer@telemotive.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] freescale-mx35-3-stack: Add mmc0
Date: Fri, 8 Apr 2011 10:37:11 +0200 [thread overview]
Message-ID: <4D9EC937.7030402@telemotive.de> (raw)
In-Reply-To: <20110408064155.GR7285@pengutronix.de>
Hi Sascha,
Am 08.04.2011 08:41, schrieb Sascha Hauer:
> Hi Thomas,
>
> On Thu, Apr 07, 2011 at 09:57:19AM +0200, Thomas Mayer wrote:
>> Signed-off-by: Thomas Mayer<thomas.mayer@telemotive.de>
>> ---
>> arch/arm/boards/freescale-mx35-3-stack/3stack.c | 4 ++++
>> 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boards/freescale-mx35-3-stack/3stack.c b/arch/arm/boards/freescale-mx35-3-stack/3stack.c
>> index 127bfb4..a4cbbe1 100644
>> --- a/arch/arm/boards/freescale-mx35-3-stack/3stack.c
>> +++ b/arch/arm/boards/freescale-mx35-3-stack/3stack.c
>> @@ -199,6 +199,10 @@ static int f3s_devices_init(void)
>> break;
>> }
>>
>> +#ifdef CONFIG_MCI_IMX_ESDHC
>> + imx35_add_mmc0(NULL);
>> +#endif
> No ifdef here, please. Registering a device without a driver available
> doesn't hurt, except for a few bytes of binary space.
>
thanks for the advice. New patch is on the way...
Regards,
Thomas
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-04-08 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 7:57 Thomas Mayer
2011-04-08 6:41 ` Sascha Hauer
2011-04-08 8:37 ` Thomas Mayer [this message]
2011-04-08 8:28 Thomas Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9EC937.7030402@telemotive.de \
--to=thomas.mayer@telemotive.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox