From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1ROSGZ-0008Ir-H5 for barebox@lists.infradead.org; Thu, 10 Nov 2011 10:53:56 +0000 Message-ID: <4EBBAD3A.5060805@pengutronix.de> Date: Thu, 10 Nov 2011 11:53:46 +0100 From: Marc Kleine-Budde MIME-Version: 1.0 References: <1320874797-14270-1-git-send-email-lucas.demarchi@profusion.mobi> <1320874797-14270-2-git-send-email-lucas.demarchi@profusion.mobi> In-Reply-To: <1320874797-14270-2-git-send-email-lucas.demarchi@profusion.mobi> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8370820203614967180==" Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/4] Make fprintf return number of bytes written To: Lucas De Marchi Cc: barebox@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============8370820203614967180== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig211E87E5F2C53DDD5337C082" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig211E87E5F2C53DDD5337C082 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/09/2011 10:39 PM, Lucas De Marchi wrote: > Return number of bytes written, like its siblings function. This also > removes the warning below on gcc >=3D 4.6. >=20 > common/console.c:333:7: warning: variable =E2=80=98i=E2=80=99 set but n= ot used > [-Wunused-but-set-variable] please use one tab not 8 spaces for indention. Marc > Signed-off-by: Lucas De Marchi > --- > common/console.c | 4 +++- > common/console_simple.c | 4 +++- > include/stdio.h | 2 +- > 3 files changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/common/console.c b/common/console.c > index 06e9c29..7f2810e 100644 > --- a/common/console.c > +++ b/common/console.c > @@ -327,7 +327,7 @@ void console_flush(void) > } > EXPORT_SYMBOL(console_flush); > =20 > -void fprintf (int file, const char *fmt, ...) > +int fprintf (int file, const char *fmt, ...) > { > va_list args; > uint i; > @@ -343,6 +343,8 @@ void fprintf (int file, const char *fmt, ...) > =20 > /* Print the string */ > fputs (file, printbuffer); > + > + return i; > } > EXPORT_SYMBOL(fprintf); > =20 > diff --git a/common/console_simple.c b/common/console_simple.c > index 7304d8e..d73af98 100644 > --- a/common/console_simple.c > +++ b/common/console_simple.c > @@ -45,7 +45,7 @@ int vprintf (const char *fmt, va_list args) > } > EXPORT_SYMBOL(vprintf); > =20 > -void fprintf (int file, const char *fmt, ...) > +int fprintf (int file, const char *fmt, ...) > { > va_list args; > uint i; > @@ -61,6 +61,8 @@ void fprintf (int file, const char *fmt, ...) > =20 > /* Print the string */ > fputs(file, printbuffer); > + > + return i; > } > EXPORT_SYMBOL(fprintf); > =20 > diff --git a/include/stdio.h b/include/stdio.h > index a0d81d3..0c68fa8 100644 > --- a/include/stdio.h > +++ b/include/stdio.h > @@ -54,7 +54,7 @@ int vscnprintf(char *buf, size_t size, const char *fm= t, va_list args); > #define stderr 2 > #define MAX_FILES 128 > =20 > -void fprintf(int file, const char *fmt, ...) __attribute__ ((format(__= printf__, 2, 3))); > +int fprintf(int file, const char *fmt, ...) __attribute__ ((format(__p= rintf__, 2, 3))); > int fputs(int file, const char *s); > int fputc(int file, const char c); > int ftstc(int file); --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --------------enig211E87E5F2C53DDD5337C082 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk67rT0ACgkQjTAFq1RaXHPsIACeKHqNZfrl34qGNA4burGSmXZS UBIAoI9p/LRLy2dSgSZXKRdN+xtvW6Sj =GuEJ -----END PGP SIGNATURE----- --------------enig211E87E5F2C53DDD5337C082-- --===============8370820203614967180== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox --===============8370820203614967180==--