From: Alan Ott <alan@signal11.us>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] common: Make MENU depend on PROCESS_ESCAPE_SEQUENCE
Date: Mon, 21 May 2012 23:35:02 -0400 [thread overview]
Message-ID: <4FBB0966.4060908@signal11.us> (raw)
In-Reply-To: <27196FB3-68EB-4583-9AF3-B256AE562D72@jcrosoft.com>
On 05/21/2012 10:40 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Hi
>
> Please revert break my work on at91bootstrap where we use the menu without any shell support
>
> And the does work with or without hush support
Upon closer inspection, it should be:
config MENU
bool
prompt "Menu Framework"
+ select PROCESS_ESCAPE_SEQUENCE if SHELL_HUSH
I have posted v2 which does this, and I agree that the original patch
should be reverted in favor of the new one.
Steps to reproduce on the master branch:
1. build on amd64 (no ARCH= or CROSS_COMPILE= or anything else)
2. make distclean
3. make menuconfig
4. Select "Menu Framework" from General Settings
5. leave everything else default.
6. make
7. output at [1] (link error).
Alan.
[1]
LD barebox
common/built-in.o: In function `print_menu_entry':
menu.c:(.text+0x5415): undefined reference to `process_escape_sequence'
common/built-in.o: In function `print_menu':
menu.c:(.text+0x54a3): undefined reference to `process_escape_sequence'
collect2: ld returned 1 exit status
make: *** [barebox] Error 1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-05-22 3:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 15:53 Alan Ott
2012-05-21 20:06 ` Sascha Hauer
2012-05-22 2:40 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-22 3:35 ` Alan Ott [this message]
2012-05-21 22:44 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-22 2:22 ` [PATCH] common: Make HUSH_SHELL select PROCESS_ESCAPE_SEQUENCE Alan Ott
2012-05-22 3:32 ` [PATCH v2] common: Make MENU select PROCESS_ESCAPE_SEQUENCE if HUSH_SHELL is selected Alan Ott
2012-05-22 9:27 ` Jean-Christophe PLAGNIOL-VILLARD
2012-05-22 15:08 ` Alan Ott
2012-05-22 19:04 ` Sascha Hauer
2012-05-22 2:24 ` [PATCH] common: Make MENU depend on PROCESS_ESCAPE_SEQUENCE Alan Ott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBB0966.4060908@signal11.us \
--to=alan@signal11.us \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox