From: Alexey Galakhov <agalakhov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] Add FriendlyArm Tiny210 board (S5PV210)
Date: Mon, 28 May 2012 15:38:28 +0600 [thread overview]
Message-ID: <4FC34794.7030301@gmail.com> (raw)
In-Reply-To: <20120524201106.GC30400@pengutronix.de>
On 25.05.2012 02:11, Sascha Hauer wrote:
> On Thu, May 24, 2012 at 07:27:45PM +0600, Alexey Galakhov wrote:
>> Signed-off-by: Alexey Galakhov <agalakhov@gmail.com>
>> ---
>> +
>> +#define ADDR_V210_SDMMC_BASE 0xD0037488
>> +#define ADDR_CopySDMMCtoMem 0xD0037F98
>> +
>> +#define RR(x) (*(volatile uint32_t*)(x))
>> +
>
> why not use regular readl/writel here?
Ok. Aren't readl/writel for register access? This is "not a register"
(although there is in fact no differnce).
> Can we do without pll init? If not, the ifdef should not be here.
The PLL comes initialized in some way from the iROM boot. It may or may
not work depending on the hardware actually used. Looks like DRAM and
UART are OK but others may not work.
> Does it make sense to run this code without SDRAM setup code? It seems
> the ifdef should not be here. Without SDRAM setup code you'll jump to
> nirvana below.
Ok. Thanks.
> Please use DEVICE_ID_DYNAMIC instead of -1.
Ok, thanks.
Regards,
Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-05-28 9:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 13:27 [RFC:PATCH 0/2] Revised S5PV210 DRAM support Alexey Galakhov
2012-05-24 13:27 ` [PATCH 1/2] S5P " Alexey Galakhov
2012-05-24 20:13 ` Sascha Hauer
2012-05-24 13:27 ` [PATCH 2/2] Add FriendlyArm Tiny210 board (S5PV210) Alexey Galakhov
2012-05-24 20:11 ` Sascha Hauer
2012-05-28 9:38 ` Alexey Galakhov [this message]
2012-07-02 15:53 [PATCH 0/2] Very minimal support S5PV210 board (Tiny210) Alexey Galakhov
2012-07-02 15:53 ` [PATCH 2/2] Add FriendlyArm Tiny210 board (S5PV210) Alexey Galakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC34794.7030301@gmail.com \
--to=agalakhov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox