mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Schenk, Gavin" <G.Schenk@eckelmann.de>
To: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"barebox@lists.infradead.org" <barebox@lists.infradead.org>
Cc: "Götzinger, Jonathan" <J.Goetzinger@eckelmann.de>
Subject: Re: [PATCH] of: fix reproducible node name for legacy vs. new partition binding
Date: Wed, 17 Oct 2018 11:07:45 +0000	[thread overview]
Message-ID: <5017d68f9bbcab2c4e3af5c20d29d3452fe6410f.camel@eckelmann.de> (raw)
In-Reply-To: <20181017084707.11878-1-s.hauer@pengutronix.de>

Hi,

On Wed, 2018-10-17 at 10:47 +0200, Sascha Hauer wrote:
> the of_reproducible_name mechanism is used to find a partition node
> from the barebox devicetree in the Linux devicetree. Unfortunately
> we have two different partition bindings. In the legacy one the partition
> nodes are directly under the hardware devicenode whereas in the new
> binding the partitions are under an additional partitions subnode.
> This means we get two different (not so) reproducible names when
> the barebox devicetree uses the legacy binding and the Linux devicetree
> uses the new binding (or the other way round). To get the same
> name then for these cases we drop the partitions subnode from the
> reproducible name.
> 
> This makes the partition fixup in barebox-state work when the barebox
> devicetree uses another binding than the Linux devicetree.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Tested-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Tested-by: Gavin Schenk <g.schenk@eckelmann.de>

What I did to test it:

1. [x] of_partition_binding=new in barebox and barebox-state in Linux is working.
2. [ ] set of_partition_binding=legacy in barebox and barebox-state in Linux fails.
3. [x] apply the patch and rebuild and install barebox
4. [x] set of_partition_binding=legacy and barebox-state in Linux is working again \o/.

Is this test sufficient?
If not what are other usefull testcases?

Thanks and Regards
Gavin Schenk


-- 
Eckelmann AG
Vorstand: Dipl.-Ing. Peter Frankenbach (Sprecher) Dipl.-Wi.-Ing. Philipp Eckelmann
Dr.-Ing. Marco Münchhof Dr.-Ing. Frank Uhlemann
Vorsitzender des Aufsichtsrats: Hubertus G. Krossa
Stv. Vorsitzender des Aufsichtsrats: Dr.-Ing. Gerd Eckelmann
Sitz der Gesellschaft: Berliner Str. 161, 65205 Wiesbaden, Amtsgericht Wiesbaden HRB 12636
http://www.eckelmann.de
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-10-17 11:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  8:47 Sascha Hauer
2018-10-17 11:07 ` Schenk, Gavin [this message]
2018-10-18  7:23   ` s.hauer
2018-10-18  9:07     ` Schenk, Gavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5017d68f9bbcab2c4e3af5c20d29d3452fe6410f.camel@eckelmann.de \
    --to=g.schenk@eckelmann.de \
    --cc=J.Goetzinger@eckelmann.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox