[PATCH] Enable pull-up on Rx serial ports for the CALAO MB-QIL-A9260

[PATCH] Enable pull-up on Rx serial ports for the CALAO MB-QIL-A9260

[gregory hermant]

This patch prevents to stop the autoboot randomly for the CALAO MB-QIL-A9260.
Indeed on this board, there's no pull-up on the RX inputs for the DBGU, COM1 & COM2 serial port.
With pull-up enabled, there's no longer unwanted character received from these console (CONFIG_CONSOLE_ACTIVATE_ALL=y). 
  
Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
---
 arch/arm/boards/qil-a9260/init.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boards/qil-a9260/init.c b/arch/arm/boards/qil-a9260/init.c
index 305d733..b43cace 100644
--- a/arch/arm/boards/qil-a9260/init.c
+++ b/arch/arm/boards/qil-a9260/init.c
@@ -196,11 +196,17 @@ device_initcall(qil_a9260_devices_init);
 static int qil_a9260_console_init(void)
 {
 	at91_register_uart(0, 0);
+	at91_set_A_periph(AT91_PIN_PB14, 1);    /* Enable pull-up on DRXD */
+
 	at91_register_uart(1, ATMEL_UART_CTS | ATMEL_UART_RTS
 			   | ATMEL_UART_DTR | ATMEL_UART_DSR | ATMEL_UART_DCD
 			   | ATMEL_UART_RI);
+
 	at91_register_uart(2, ATMEL_UART_CTS | ATMEL_UART_RTS);
+	at91_set_A_periph(AT91_PIN_PB7, 1);	/* Enable pull-up on RXD1 */
+
 	at91_register_uart(3, ATMEL_UART_CTS | ATMEL_UART_RTS);
+	at91_set_A_periph(AT91_PIN_PB9, 1);	/* Enable pull-up on RXD2 */
 
 	return 0;
 }
-- 
1.5.6.3



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] Enable pull-up on Rx serial ports for the CALAO MB-QIL-A9260

[Sascha Hauer]

On Fri, Aug 03, 2012 at 12:00:26PM +0200, gregory hermant wrote:
> This patch prevents to stop the autoboot randomly for the CALAO MB-QIL-A9260.
> Indeed on this board, there's no pull-up on the RX inputs for the DBGU, COM1 & COM2 serial port.
> With pull-up enabled, there's no longer unwanted character received from these console (CONFIG_CONSOLE_ACTIVATE_ALL=y). 
>   
> Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>

Applied, thanks

Sascha

> ---
>  arch/arm/boards/qil-a9260/init.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boards/qil-a9260/init.c b/arch/arm/boards/qil-a9260/init.c
> index 305d733..b43cace 100644
> --- a/arch/arm/boards/qil-a9260/init.c
> +++ b/arch/arm/boards/qil-a9260/init.c
> @@ -196,11 +196,17 @@ device_initcall(qil_a9260_devices_init);
>  static int qil_a9260_console_init(void)
>  {
>  	at91_register_uart(0, 0);
> +	at91_set_A_periph(AT91_PIN_PB14, 1);    /* Enable pull-up on DRXD */
> +
>  	at91_register_uart(1, ATMEL_UART_CTS | ATMEL_UART_RTS
>  			   | ATMEL_UART_DTR | ATMEL_UART_DSR | ATMEL_UART_DCD
>  			   | ATMEL_UART_RI);
> +
>  	at91_register_uart(2, ATMEL_UART_CTS | ATMEL_UART_RTS);
> +	at91_set_A_periph(AT91_PIN_PB7, 1);	/* Enable pull-up on RXD1 */
> +
>  	at91_register_uart(3, ATMEL_UART_CTS | ATMEL_UART_RTS);
> +	at91_set_A_periph(AT91_PIN_PB9, 1);	/* Enable pull-up on RXD2 */
>  
>  	return 0;
>  }
> -- 
> 1.5.6.3
> 
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox