From: Carlo Caione <carlo.caione@gmail.com>
To: barebox-request <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] Add bcm2835/Raspberry-Pi support
Date: Thu, 20 Sep 2012 18:18:14 +0200 [thread overview]
Message-ID: <505B41C6.5010907@gmail.com> (raw)
In-Reply-To: <1348155606.3514.21.camel@coredoba.hi.pengutronix.de>
On 20/09/2012 17:40, Jan Lübbe wrote:
> Hi,
>
> I've tried your patches and the boot fine:
[cut]
> The first patch has some white-space warnings which should be fixed:
> $ git am ~/\[PATCH_1_2\]_Add_bcm2835_Raspberry-Pi_support.mbox
> Applying: Add bcm2835/Raspberry-Pi support
> /ptx/work/dude/jlu/raspi/barebox/.git/rebase-apply/patch:358:
> trailing whitespace. .rate = UART0_CLOCK,
> /ptx/work/dude/jlu/raspi/barebox/.git/rebase-apply/patch:410: space
> before tab in indent. uint32_t rstc;
> /ptx/work/dude/jlu/raspi/barebox/.git/rebase-apply/patch:411:
> trailing whitespace.
>
> /ptx/work/dude/jlu/raspi/barebox/.git/rebase-apply/patch:415:
> trailing whitespace.
>
> /ptx/work/dude/jlu/raspi/barebox/.git/rebase-apply/patch:595:
> trailing whitespace.
>
> warning: squelched 1 whitespace error warning: 6 lines add
> whitespace errors.
>
> So feel free to add my Tested-By for the cleaned-up version:
> Tested-By: Jan Luebbe <jlu@pengutronix.de>
Thank you for testing it.
I'll fix the whitespace errors in the next patches.
Best,
--
Carlo Caione
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-09-20 16:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 20:30 Carlo Caione
2012-09-18 20:30 ` [PATCH 2/2] Add Raspberry-Pi defconfig Carlo Caione
2012-09-18 22:07 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-19 22:19 ` Carlo Caione
2012-09-20 5:19 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-18 22:06 ` [PATCH 1/2] Add bcm2835/Raspberry-Pi support Jean-Christophe PLAGNIOL-VILLARD
2012-09-19 7:42 ` Juergen Beisert
2012-09-19 8:14 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-19 8:54 ` Juergen Beisert
2012-09-19 9:37 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-19 9:10 ` Jan Lübbe
2012-09-19 10:00 ` Carlo Caione
2012-09-19 10:08 ` Jan Lübbe
2012-09-19 10:49 ` Carlo Caione
2012-09-19 10:49 ` Marc Kleine-Budde
2012-09-19 11:10 ` Carlo Caione
2012-09-19 11:13 ` Marc Kleine-Budde
2012-09-20 10:25 ` Thomas Petazzoni
2012-09-20 15:40 ` Jan Lübbe
2012-09-20 16:18 ` Carlo Caione [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B41C6.5010907@gmail.com \
--to=carlo.caione@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox