From: Teresa Gamez <t.gamez@phytec.de>
To: barebox@lists.infradead.org
Subject: OMAP SPI adding inline functions
Date: Fri, 28 Sep 2012 16:39:29 +0200 [thread overview]
Message-ID: <5065B6A1.7060802@phytec.de> (raw)
Hello Jan,
I'm working on adding inline functions for omap devices to reduce the
board code. I have noticed that the omap3_spi driver doesn't fit in the
scheme. It uses the dev->id to set the master->bus_num. So I have to
pass the argument here and can not use the DEVICE_ID_DYNAMIC define. Has
that been intentional? Wouldn't it be better to pass this over
platform_data like in the altera_spi driver does?
I allready noticed that it's done the same way in the kernel...
Sadly I'm on vacation next week so my patches have to wait.
And sorry for not having time to look at your lowlevel support of am335x.
Regards
Teresa
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
reply other threads:[~2012-09-28 14:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5065B6A1.7060802@phytec.de \
--to=t.gamez@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox