Re: [PATCH] of: add ranges address translation for default bus

[Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>]

On 05/19/2013 09:34 AM, Sascha Hauer wrote:
> Hi Sebastian,
>
> On Mon, May 13, 2013 at 01:09:06AM +0200, Sebastian Hesselbarth wrote:
>> This patch adds address translation for default bus types. It has been
>> shamelessly ported from Linux device tree address translation with the
>> following exceptions:
>> - only default bus map and translate are supported
>> - of_bus has not been ported
>> - check for #size-cells>  0 has been removed
>>
>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com>
>
> I just gave this one a test.
>
> First of all you dropped 1:1 translation, see the attached fixup.

Sascha,

I know I dropped it, but have you tried empty/bool properties?
I had no luck with an empty/bool ranges, so I removed the 1:1
translation by empty property and wanted to take a look at bool
props first.

Could be that, I was just tired and made a mistake. Will investigate
as soon as Thomas aggrees to my next consolidation patch set.

> Then, since this code duplicates the majority of drivers/of/address.c,
> would it make sense to move it to the same file in barebox aswell?

In general, yes. If you copy the behavior of linux, we should not
try to merge individual base.c, address.c, whatever.c out of drivers/of
into differently named files.

Sebastian


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox