mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	barebox@lists.infradead.org
Subject: Re: [PATCH] of: add ranges address translation for default bus
Date: Sun, 19 May 2013 12:49:31 +0200	[thread overview]
Message-ID: <5198AE3B.4080204@gmail.com> (raw)
In-Reply-To: <20130519103936.GA32299@pengutronix.de>

On 05/19/2013 12:39 PM, Sascha Hauer wrote:
> On Sun, May 19, 2013 at 10:07:26AM +0200, Sebastian Hesselbarth wrote:
>> On 05/19/2013 09:34 AM, Sascha Hauer wrote:
>>> First of all you dropped 1:1 translation, see the attached fixup.
>>
>> I know I dropped it, but have you tried empty/bool properties?
>> I had no luck with an empty/bool ranges, so I removed the 1:1
>> translation by empty property and wanted to take a look at bool
>> props first.
>
> Probably because of_get_property doesn't seem to be 100% Linux
> compatible. Our version returns NULL for empty properties whereas
> the Linux version seems to return some valid pointer for zero length
> properties.

I knew there was something ;)

> I used of_find_property instead in my fixup, but maybe it's better
> to change the behaviour of of_get_property instead.

Yes. With the next mvebu consolidation patches, we get rid of any
board specific code for Armada 370/XP, Dove, and Kirkwood. On top
of that, I then start with replacing static timer and uart
registration with DT probed devices. That is when I need ranges
translation.

I can rework DT ranges and bool properties, send a patch set before
mvebu DT, and you drop this one.

But I will not start working on it before Thomas finds some time to
test/comment on the (not yet) published consolidation patches.

Sebastian

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-05-19 10:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-12 23:09 Sebastian Hesselbarth
2013-05-19  7:34 ` Sascha Hauer
2013-05-19  8:07   ` Sebastian Hesselbarth
2013-05-19 10:39     ` Sascha Hauer
2013-05-19 10:49       ` Sebastian Hesselbarth [this message]
2013-05-19 15:20         ` Thomas Petazzoni
2013-06-11  9:33   ` Sebastian Hesselbarth
2013-06-13  9:25     ` Sascha Hauer
2013-06-13  9:38       ` Sebastian Hesselbarth
2013-06-13 12:48         ` Sascha Hauer
2013-06-13 18:50           ` Sebastian Hesselbarth
2013-06-17  7:47             ` Sascha Hauer
2013-06-17 10:23               ` Sebastian Hesselbarth
2013-06-17 10:40                 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5198AE3B.4080204@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox