From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ea0-x22d.google.com ([2a00:1450:4013:c01::22d]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UsGvV-00089t-TE for barebox@lists.infradead.org; Thu, 27 Jun 2013 18:28:14 +0000 Received: by mail-ea0-f173.google.com with SMTP id g15so580830eak.32 for ; Thu, 27 Jun 2013 11:27:52 -0700 (PDT) Message-ID: <51CC8423.301@gmail.com> Date: Thu, 27 Jun 2013 20:27:47 +0200 From: Sebastian Hesselbarth MIME-Version: 1.0 References: <1372152047-28134-1-git-send-email-sebastian.hesselbarth@gmail.com> <20130627065118.GA10414@pengutronix.de> <51CBEEB2.5090209@gmail.com> <20130627085816.GF516@pengutronix.de> <51CBFF3E.6090306@gmail.com> <20130627181923.GH516@pengutronix.de> In-Reply-To: <20130627181923.GH516@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 0/9] OF: address and device related sync and cleanup To: Sascha Hauer Cc: barebox@lists.infradead.org On 06/27/13 20:19, Sascha Hauer wrote: > On Thu, Jun 27, 2013 at 11:00:46AM +0200, Sebastian Hesselbarth wrote: >> On 06/27/13 10:58, Sascha Hauer wrote: >>> On Thu, Jun 27, 2013 at 09:50:10AM +0200, Sebastian Hesselbarth wrote: >>>> On 06/27/13 08:51, Sascha Hauer wrote: >>>>> Applied this series with the change that I removed the dead code >>>>> ifdeffed with CONFIG_PPC_DCR. >>>> >>>> Ok, great! Next patch sets will be focused on actually using the >>>> DT improvements. I have an SPI driver for MACH_MVEBU ready and >>>> running, and I am working on importing generic SDHCI from Linux. >>> >>> The sdhc driver in Linux is a big piece of shit which uses the wrong >>> abstraction model. This is shown by the fact that 32bits are not enough >>> to abstract the quirks. Even with all these quirks the i.MX part of this >>> driver has to implement driver logic in the register access functions. >>> That just insane. I'm not really looking forward to add this driver >>> to barebox. >> >> Ok, fair enough. Then I'll be adding the required callbacks to Dove >> SDHCI driver directly based on current barebox i.MX driver. > > I think for the SDHC a library approach would be good: Add a new driver > and share common code/helper functions. I recently factored out the > register defines as a start so that these can be shared. Yeah, I just working at SDHCI driver for Dove and wonder if I start to wrap my brain around readl/writel or go with readb/w/l as it is supposed to be. As soon as I got some valid responses back from the usdcard, I have another look at sdhci.h and a generic approach. Sebastian _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox