From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
barebox@lists.infradead.org
Subject: Re: [PATCH 3/6] ARM: mvebu: introduce multi image support
Date: Tue, 13 Aug 2013 15:30:38 +0200 [thread overview]
Message-ID: <520A34FE.2020008@gmail.com> (raw)
In-Reply-To: <1376378772-25649-4-git-send-email-s.hauer@pengutronix.de>
On 08/13/13 09:26, Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm/boards/solidrun-cubox/Makefile | 1 +
> arch/arm/boards/solidrun-cubox/lowlevel.c | 37 +++++++++++++++++++++++++++++
> arch/arm/configs/solidrun_cubox_defconfig | 6 ++++-
> arch/arm/dts/Makefile | 1 +
> arch/arm/mach-mvebu/Kconfig | 1 +
> arch/arm/mach-mvebu/Makefile | 2 +-
> arch/arm/mach-mvebu/common.c | 4 ++--
> arch/arm/mach-mvebu/include/mach/lowlevel.h | 2 +-
> arch/arm/mach-mvebu/lowlevel.c | 2 +-
> images/.gitignore | 2 ++
> images/Makefile | 4 +++-
> images/Makefile.mvebu | 26 ++++++++++++++++++++
> scripts/Makefile.lib | 3 +++
> 13 files changed, 84 insertions(+), 7 deletions(-)
> create mode 100644 arch/arm/boards/solidrun-cubox/lowlevel.c
> create mode 100644 images/Makefile.mvebu
[...]
> diff --git a/arch/arm/boards/solidrun-cubox/lowlevel.c b/arch/arm/boards/solidrun-cubox/lowlevel.c
> new file mode 100644
> index 0000000..fdf5a7e
> --- /dev/null
> +++ b/arch/arm/boards/solidrun-cubox/lowlevel.c
> @@ -0,0 +1,37 @@
[...]
> +ENTRY_FUNCTION(start_solidrun_cubox)(void)
> +{
> + uint32_t fdt;
> +
> + __barebox_arm_head();
> +
> + arm_cpu_lowlevel_init();
> +
> + fdt = (uint32_t)__dtb_dove_cubox_start - get_runtime_offset();
> +
> + mvebu_barebox_entry(fdt);
> +}
[...]
> diff --git a/arch/arm/mach-mvebu/lowlevel.c
b/arch/arm/mach-mvebu/lowlevel.c
> index 3f64c4a..11810cc 100644
> --- a/arch/arm/mach-mvebu/lowlevel.c
> +++ b/arch/arm/mach-mvebu/lowlevel.c
> @@ -24,5 +24,5 @@
> void __naked barebox_arm_reset_vector(void)
> {
> arm_cpu_lowlevel_init();
> - mvebu_barebox_entry();
> + mvebu_barebox_entry(0);
> }
Sascha,
thanks for the patch set, I'll give it a go soon.
I understand that this is just a first step, but you are adding extra
lowlevel init to boards/solidrun-cubox/lowlevel.c but in the end it
should be part of mach-mvebu/lowlevel.c instead?
I have a some MVEBU boards with Dove and Armada 370 available and
could extend the patches to have a single lowlevel init again.
Sebastian
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-08-13 13:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 7:26 [PATCH] cubox " Sascha Hauer
2013-08-13 7:26 ` [PATCH 1/6] ARM: mvebu: move Makefile entries back to arch/arm/Makefile Sascha Hauer
2013-08-13 7:26 ` [PATCH 2/6] ARM: dts: cubox: fix stdout-path property Sascha Hauer
2013-08-13 7:26 ` [PATCH 3/6] ARM: mvebu: introduce multi image support Sascha Hauer
2013-08-13 13:30 ` Sebastian Hesselbarth [this message]
2013-08-13 14:15 ` Sascha Hauer
2013-08-13 14:22 ` Sebastian Hesselbarth
2013-08-14 6:20 ` Sascha Hauer
2013-08-13 15:35 ` Sebastian Hesselbarth
2013-08-13 7:26 ` [PATCH 4/6] ARM: mvebu: dove: use uart from devicetree Sascha Hauer
2013-08-13 7:26 ` [PATCH 5/6] ARM: mvebu: dove: use timer " Sascha Hauer
2013-08-13 7:26 ` [PATCH 6/6] ARM: mvebu: cubox: Update defconfig Sascha Hauer
2013-08-13 8:12 ` [PATCH] cubox multi image support Thomas Petazzoni
2013-08-13 8:16 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A34FE.2020008@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox