From: Renaud Barbier <renaud.barbier@ge.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/4] ppc: add mpc85xx device tree fixup functions
Date: Mon, 02 Sep 2013 17:34:11 +0100 [thread overview]
Message-ID: <5224BE03.40306@ge.com> (raw)
In-Reply-To: <20130902084912.GP30088@pengutronix.de>
On 02/09/2013 09:49, Sascha Hauer wrote:
> Hi Renaud,
>
> On Fri, Aug 30, 2013 at 02:34:27PM +0100, Renaud Barbier wrote:
>> > +/* These properties specify whether the hardware supports the stashing
>> > + * of buffer descriptors in L2 cache.
>> > + */
>> > +static void fdt_add_enet_stashing(void *fdt)
>> > +{
>> > + struct device_node *node;
>> > +
>> > + node = of_find_compatible_node(fdt, NULL, "gianfar");
>> > + while (node) {
>> > + of_set_property(node, "bd-stash", NULL, 0, 1);
>> > + of_property_write_u32(node, "rx-stash-len", 96);
>> > + of_property_write_u32(node, "rx-stash-idx", 0);
>> > + node = of_find_compatible_node(node, NULL, "gianfar");
>> > + }
>> > +}
> Out of curiosity, why is this dynamically added and not part of the
> static dts file?
>
I will have to quote the original comment from U-Boot as I cannot find
a reasonable explanation why it is done this way.
Original U-boot commit:
Date: Tue Oct 7 08:09:50 2008 -0500
Have u-boot pass stashing parameters into device tree
Some cores don't support ethernet stashing at all, and some
instances have errata. Adds 3 properties to gianfar nodes
which support stashing. For now, just add this support to
85xx SoCs.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-09-02 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 13:34 [PATCH 0/4] Update P2020RDB board support to allow NFS booting Renaud Barbier
2013-08-30 13:34 ` [PATCH 1/4] of: base: import of_find_node_by_type Renaud Barbier
2013-08-30 13:34 ` [PATCH 2/4] ppc: add mpc85xx device tree fixup functions Renaud Barbier
2013-09-02 8:49 ` Sascha Hauer
2013-09-02 16:34 ` Renaud Barbier [this message]
2013-08-30 13:34 ` [PATCH 3/4] ppc: bootm: relocate fdt to valid boot memory Renaud Barbier
2013-08-30 13:34 ` [PATCH 4/4] ppc: P2020RDB configuration update Renaud Barbier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5224BE03.40306@ge.com \
--to=renaud.barbier@ge.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox