mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Daniel Schultz <d.schultz@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 4/5] arm: boards: beaglebone: Delete default env
Date: Tue, 9 May 2017 11:58:35 +0200	[thread overview]
Message-ID: <524f29f0-423f-62b9-77fb-82173f9e6c28@phytec.de> (raw)
In-Reply-To: <20170508125741.2dtqzlkicvdo2pxp@pengutronix.de>

Hi Sascha,

Am 08.05.2017 um 14:57 schrieb Sascha Hauer:
> Hi Daniel,
>
> On Fri, May 05, 2017 at 04:46:57PM +0200, Daniel Schultz wrote:
>> The Beaglebone environment should be set from outside with an application
>> specific environment.
>
> I don't understand this. What are you trying to archieve and why?
>
I thought you prefer the bootloader spec way without a predefined 
environment, but maybe I just had misunderstood you. If so, I will only 
change the mount path of the boot partition.

-- 
Mit freundlichen Grüßen,
With best regards,
   Daniel Schultz

> Sascha
>
>>
>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>> ---
>>  arch/arm/boards/beaglebone/Makefile                                 | 1 -
>>  arch/arm/boards/beaglebone/board.c                                  | 2 --
>>  arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd            | 6 ------
>>  .../arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 | 5 -----
>>  4 files changed, 14 deletions(-)
>>  delete mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd
>>  delete mode 100644 arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300
>>
>> diff --git a/arch/arm/boards/beaglebone/Makefile b/arch/arm/boards/beaglebone/Makefile
>> index 21a1a29..092c31d 100644
>> --- a/arch/arm/boards/beaglebone/Makefile
>> +++ b/arch/arm/boards/beaglebone/Makefile
>> @@ -1,3 +1,2 @@
>>  lwl-y += lowlevel.o
>>  obj-y += board.o
>> -bbenv-y += defaultenv-beaglebone
>> diff --git a/arch/arm/boards/beaglebone/board.c b/arch/arm/boards/beaglebone/board.c
>> index 5717c45..fc16aea 100644
>> --- a/arch/arm/boards/beaglebone/board.c
>> +++ b/arch/arm/boards/beaglebone/board.c
>> @@ -85,8 +85,6 @@ static int beaglebone_devices_init(void)
>>
>>  	black = is_beaglebone_black();
>>
>> -	defaultenv_append_directory(defaultenv_beaglebone);
>> -
>>  	globalvar_add_simple("board.variant", black ? "boneblack" : "bone");
>>
>>  	printf("detected 'BeagleBone %s'\n", black ? "Black" : "White");
>> diff --git a/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd b/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd
>> deleted file mode 100644
>> index aa94b2f..0000000
>> --- a/arch/arm/boards/beaglebone/defaultenv-beaglebone/boot/sd
>> +++ /dev/null
>> @@ -1,6 +0,0 @@
>> -#!/bin/sh
>> -
>> -global.bootm.image=/boot/uImage
>> -global.bootm.oftree=/boot/oftree
>> -#global.bootm.initrd=<path to initrd>
>> -global.linux.bootargs.dyn.root="root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
>> diff --git a/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300 b/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300
>> deleted file mode 100644
>> index 56313bf..0000000
>> --- a/arch/arm/boards/beaglebone/defaultenv-beaglebone/init/usb-limit-1300
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -#!/bin/sh
>> -
>> -echo -n "changing USB current limit to 1300 mA... "
>> -i2c_write -b 0 -a 0x24 -r 0x01 0x3e
>> -echo "done"
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>
>


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-05-09  9:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 14:46 [PATCH v2 1/5] arm: mach-omap: Change mountpoint of boot partitions Daniel Schultz
2017-05-05 14:46 ` [PATCH v2 2/5] arm: boards: phytec-som-am335x: Add automount script Daniel Schultz
2017-05-05 14:46 ` [PATCH v2 3/5] arm: boards: phytec-som-am335x: Update boot scripts Daniel Schultz
2017-05-05 14:46 ` [PATCH v2 4/5] arm: boards: beaglebone: Delete default env Daniel Schultz
2017-05-08 12:57   ` Sascha Hauer
2017-05-09  9:58     ` Daniel Schultz [this message]
2017-05-05 14:46 ` [PATCH v2 5/5] arm: boards: afi-gf: Update SD card boot script Daniel Schultz
2017-05-11  9:14 ` [PATCH v2 1/5] arm: mach-omap: Change mountpoint of boot partitions Sascha Hauer
2017-05-12 11:20   ` Daniel Schultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524f29f0-423f-62b9-77fb-82173f9e6c28@phytec.de \
    --to=d.schultz@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox