From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH master] sandbox: lds: fix "ELF has a LOAD segment with RWX permissions" warning
Date: Mon, 15 Jul 2024 08:04:37 +0200 [thread overview]
Message-ID: <52824a89-78d9-413a-b65b-3c3a064e7968@pengutronix.de> (raw)
In-Reply-To: <20240703190226.686987-1-a.fatoum@pengutronix.de>
On 03.07.24 21:02, Ahmad Fatoum wrote:
> With binutils 2.39+, the barebox build started emitting this warning.
> On platforms other than sandbox, we disable this warning by passing --no-warn-rwx
> to ld as we don't care for ELF attributes as they aren't used anyway.
>
> On sandbox, however, the ELF attributes matter, so disabling the warning
> completely felt wrong. Looking more into it now, we can mark the
> .barebox_rodata section in the linker file snippet we have in sandbox as
> READONLY and the warning disappears, so let's do that instead.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Please dismiss this patch. The new BAREBOX_CLASSES addition to RO_DATA_SECTION
makes the section not const anymore, so this would crash on the first class
addition. I'll send a v2 later.
> ---
> arch/sandbox/board/barebox.lds.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sandbox/board/barebox.lds.S b/arch/sandbox/board/barebox.lds.S
> index ab2801f3d207..de8552dba0ac 100644
> --- a/arch/sandbox/board/barebox.lds.S
> +++ b/arch/sandbox/board/barebox.lds.S
> @@ -5,7 +5,7 @@
> SECTIONS
> {
> . = ALIGN(64);
> - .barebox_rodata : {
> + .barebox_rodata (READONLY) : {
> RO_DATA_SECTION
> }
> }
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-07-15 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 19:02 Ahmad Fatoum
2024-07-15 6:04 ` Ahmad Fatoum [this message]
2024-07-16 11:09 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52824a89-78d9-413a-b65b-3c3a064e7968@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox