mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Markus Niebel <list-09_barebox@tqsc.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org, Markus Niebel <Markus.Niebel@tqs.de>
Subject: Re: [PATCH 2/3] mci: imx-esdhc: add DSR support
Date: Fri, 10 Jan 2014 11:23:56 +0100	[thread overview]
Message-ID: <52CFCA3C.8090802@tqsc.de> (raw)
In-Reply-To: <1389345940.570404331@f9.i.mail.ru>

Hello,
> Hello.
> 
> Пятница, 10 января 2014, 10:29 +01:00 от Markus Niebel <list-09_barebox@tqsc.de>:
>> From: Markus Niebel <Markus.Niebel@tqs.de>
>>
>> having DSR support in mci-core we need a way to
>> forward the DSR value to the driver. Add it to
>> platform data for imx-esdhc
> ...
>> diff --git a/drivers/mci/imx-esdhc.c b/drivers/mci/imx-esdhc.c
>> index 7664e7b..deb44b0 100644
>> --- a/drivers/mci/imx-esdhc.c
>> +++ b/drivers/mci/imx-esdhc.c
>> @@ -582,6 +582,8 @@ static int fsl_esdhc_probe(struct device_d *dev)
>>  	if (host->mci.f_min < 200000)
>>  		host->mci.f_min = 200000;
>>  	host->mci.f_max = rate;
>> +	host->mci.use_dsr = pdata->use_dsr;
>> +	host->mci.dsr_val = pdata->dsr_val;
> 
> What happen if device is probed from devicetree?
Thanks for pointing this out. 

As the cover says - just a RFC. We have working code for device tree under linux here.
My proposal is to pass the DSR value as an optional property to the host controller - 
then it could be parsed by mci_of_parse - but this needs to be in sync with the kernel.
Yes and the setting from pdata should be optional - since pdata is NULL in case of device tree.

Will collect comments and prepare a second round.

Markus
> 
> ---
> 


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-01-10 10:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-10  9:29 [RFC] mci: " Markus Niebel
2014-01-10  9:29 ` [PATCH 1/3] " Markus Niebel
2014-01-10 11:18   ` Sascha Hauer
2014-01-10 11:56     ` Markus Niebel
2014-01-13  8:19       ` Sascha Hauer
2014-01-10  9:29 ` [PATCH 2/3] mci: imx-esdhc: " Markus Niebel
2014-01-10  9:25   ` Alexander Shiyan
2014-01-10 10:23     ` Markus Niebel [this message]
2014-01-10  9:29 ` [PATCH 3/3] boards: tqma53: add DSR support for eMMC Markus Niebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CFCA3C.8090802@tqsc.de \
    --to=list-09_barebox@tqsc.de \
    --cc=Markus.Niebel@tqs.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox